Extend the novatek touchscreen driver to support NT36672A chip which
is found in phones like qcom/sdm845-xiaomi-beryllium-tianma.dts.
Added devicetree support for the driver and used i2c chip data to handle
the variation in chip id and wake type. Also added vcc and iovcc
regulators which are used to power the touchscreen hardware.

Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
---
Changes in v5:
- Made the chip data a local variable as it is only used during probe.
- Handle the regulator disable correctly for all exit paths in probe.
- Link to v4: https://lore.kernel.org/r/20240601-nvt-ts-devicetree-regulator-support-v4-0-e0c0174464c4@gmail.com

Changes in v4:
- Use lowercase i2c device id as suggested by Hans de Goede.
- Disable the regulators after nvt_ts_read_data during probe.
- Link to v3: https://lore.kernel.org/r/20240526-nvt-ts-devicetree-regulator-support-v3-0-aa88d10ccd9a@gmail.com

Changes in v3:
- Fix indentation in the binding as suggested by Krzysztof Kozlowski.
- Picked up Krzysztof Kozlowski's Reviewed-by tag for the binding.
- Link to v2: https://lore.kernel.org/r/20240524-nvt-ts-devicetree-regulator-support-v2-0-b74947038c44@gmail.com

Changes in v2:
- The generic i2c device id is now replaced with the correct IC variant
  provided by Hans de Goede
- Updated the bindings to reflect the latest changes and also incorporated
  the suggestions provided by Krzysztof Kozlowski
- Link to v1: https://lore.kernel.org/r/20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com

---
Joel Selvaraj (3):
      Input: novatek-nvt-ts: replace generic i2c device id with specific IC variant
      dt-bindings: input: document Novatek NVT touchscreen controller
      Input: novatek-nvt-ts: add support for NT36672A touchscreen

 .../bindings/input/touchscreen/novatek,nvt-ts.yaml | 62 ++++++++++++++++++++
 MAINTAINERS                                        |  1 +
 drivers/input/touchscreen/novatek-nvt-ts.c         | 67 ++++++++++++++++++++--
 drivers/platform/x86/x86-android-tablets/other.c   |  2 +-
 4 files changed, 125 insertions(+), 7 deletions(-)
---
base-commit: 6578aac6a270bd6deb9f9319b991dd430de263dd
change-id: 20240518-nvt-ts-devicetree-regulator-support-ac9e49b78a16

Best regards,
-- 
Joel Selvaraj <joelselvaraj.oss@gmail.com>

On Sat, Jun 01, 2024 at 03:44:42PM -0500, Joel Selvaraj via B4 Relay wrote:
> Extend the novatek touchscreen driver to support NT36672A chip which
> is found in phones like qcom/sdm845-xiaomi-beryllium-tianma.dts.
> Added devicetree support for the driver and used i2c chip data to handle
> the variation in chip id and wake type. Also added vcc and iovcc
> regulators which are used to power the touchscreen hardware.
> 
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>

Applied the series, it will go in the next merge window. Sorry for the
delay.

Thanks.

-- 
Dmitry

> Applied the series, it will go in the next merge window. Sorry for the
> delay.

Nice to know. thank you!
- Joel Selvaraj

Hi,

A gentle ping to the maintainers/reviewers. I was initially hoping this 
patch would land in 6.11. And it got kind of missed. So I am currently 
hoping it would land in 6.12. But I haven't seen any update in the 
patch. There is no hurry and can wait for 6.13 or future. Just don't 
want the patch to be forgotten/lost/missed. Kindly let me know if any 
further changes are required! I will be happy to fix them.

Thank you,
Joel Selvaraj

On 6/1/24 15:44, Joel Selvaraj via B4 Relay wrote:
> Extend the novatek touchscreen driver to support NT36672A chip which
> is found in phones like qcom/sdm845-xiaomi-beryllium-tianma.dts.
> Added devicetree support for the driver and used i2c chip data to handle
> the variation in chip id and wake type. Also added vcc and iovcc
> regulators which are used to power the touchscreen hardware.
> 
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
> ---
> Changes in v5:
> - Made the chip data a local variable as it is only used during probe.
> - Handle the regulator disable correctly for all exit paths in probe.
> - Link to v4: https://lore.kernel.org/r/20240601-nvt-ts-devicetree-regulator-support-v4-0-e0c0174464c4@gmail.com
> 
> Changes in v4:
> - Use lowercase i2c device id as suggested by Hans de Goede.
> - Disable the regulators after nvt_ts_read_data during probe.
> - Link to v3: https://lore.kernel.org/r/20240526-nvt-ts-devicetree-regulator-support-v3-0-aa88d10ccd9a@gmail.com
> 
> Changes in v3:
> - Fix indentation in the binding as suggested by Krzysztof Kozlowski.
> - Picked up Krzysztof Kozlowski's Reviewed-by tag for the binding.
> - Link to v2: https://lore.kernel.org/r/20240524-nvt-ts-devicetree-regulator-support-v2-0-b74947038c44@gmail.com
> 
> Changes in v2:
> - The generic i2c device id is now replaced with the correct IC variant
>    provided by Hans de Goede
> - Updated the bindings to reflect the latest changes and also incorporated
>    the suggestions provided by Krzysztof Kozlowski
> - Link to v1: https://lore.kernel.org/r/20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com
> 
> ---
> Joel Selvaraj (3):
>        Input: novatek-nvt-ts: replace generic i2c device id with specific IC variant
>        dt-bindings: input: document Novatek NVT touchscreen controller
>        Input: novatek-nvt-ts: add support for NT36672A touchscreen
> 
>   .../bindings/input/touchscreen/novatek,nvt-ts.yaml | 62 ++++++++++++++++++++
>   MAINTAINERS                                        |  1 +
>   drivers/input/touchscreen/novatek-nvt-ts.c         | 67 ++++++++++++++++++++--
>   drivers/platform/x86/x86-android-tablets/other.c   |  2 +-
>   4 files changed, 125 insertions(+), 7 deletions(-)
> ---
> base-commit: 6578aac6a270bd6deb9f9319b991dd430de263dd
> change-id: 20240518-nvt-ts-devicetree-regulator-support-ac9e49b78a16
> 
> Best regards,

On 28/09/2024 07:45, Joel Selvaraj wrote:
> Hi,
> 
> A gentle ping to the maintainers/reviewers. I was initially hoping this 
> patch would land in 6.11. And it got kind of missed. So I am currently 
> hoping it would land in 6.12. But I haven't seen any update in the 
> patch. There is no hurry and can wait for 6.13 or future. Just don't 
> want the patch to be forgotten/lost/missed. Kindly let me know if any 
> further changes are required! I will be happy to fix them.

We are still in merge window, so nothing can happen with your patches.
Pinging during merge window is not welcomed, just unnecessary noise.
Wait till merge window finishes and then ping, or better resend.

Your patch waited indeed way too long, but if you wanted it to reach
v6.12, then you should have done something earlier. No one has it in
their inbox anymore.

Please resend with accumulated tags, assuming there is no outstanding
review comments, after the merge window.

Best regards,
Krzysztof

Hi Krzysztof Kozlowski,

On 9/28/24 02:49, Krzysztof Kozlowski wrote:
> On 28/09/2024 07:45, Joel Selvaraj wrote:
>> Hi,
>>
>> A gentle ping to the maintainers/reviewers. I was initially hoping this
>> patch would land in 6.11. And it got kind of missed. So I am currently
>> hoping it would land in 6.12. But I haven't seen any update in the
>> patch. There is no hurry and can wait for 6.13 or future. Just don't
>> want the patch to be forgotten/lost/missed. Kindly let me know if any
>> further changes are required! I will be happy to fix them.
> 
> We are still in merge window, so nothing can happen with your patches.
> Pinging during merge window is not welcomed, just unnecessary noise.
> Wait till merge window finishes and then ping, or better resend.

Ah I see. Understood. Sorry for the noise.

> Your patch waited indeed way too long, but if you wanted it to reach
> v6.12, then you should have done something earlier. No one has it in
> their inbox anymore.
> 
> Please resend with accumulated tags, assuming there is no outstanding
> review comments, after the merge window.

Will do. Thanks!
Joel Selvaraj
> 
> Best regards,
> Krzysztof
>