make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/configfs/configfs_sample.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 samples/configfs/configfs_sample.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
index 37a657b25d58..fd5d163828c5 100644
--- a/samples/configfs/configfs_sample.c
+++ b/samples/configfs/configfs_sample.c
@@ -364,4 +364,5 @@ static void __exit configfs_example_exit(void)
 
 module_init(configfs_example_init);
 module_exit(configfs_example_exit);
+MODULE_DESCRIPTION("Sample configfs module");
 MODULE_LICENSE("GPL");

---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-samples-configfs-946b278a9d47

On 6/1/2024 5:12 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/configfs/configfs_sample.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  samples/configfs/configfs_sample.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
> index 37a657b25d58..fd5d163828c5 100644
> --- a/samples/configfs/configfs_sample.c
> +++ b/samples/configfs/configfs_sample.c
> @@ -364,4 +364,5 @@ static void __exit configfs_example_exit(void)
>  
>  module_init(configfs_example_init);
>  module_exit(configfs_example_exit);
> +MODULE_DESCRIPTION("Sample configfs module");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-configfs-946b278a9d47
> 

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.

On 6/20/2024 9:46 AM, Jeff Johnson wrote:
> On 6/1/2024 5:12 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/configfs/configfs_sample.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  samples/configfs/configfs_sample.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
>> index 37a657b25d58..fd5d163828c5 100644
>> --- a/samples/configfs/configfs_sample.c
>> +++ b/samples/configfs/configfs_sample.c
>> @@ -364,4 +364,5 @@ static void __exit configfs_example_exit(void)
>>  
>>  module_init(configfs_example_init);
>>  module_exit(configfs_example_exit);
>> +MODULE_DESCRIPTION("Sample configfs module");
>>  MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: b050496579632f86ee1ef7e7501906db579f3457
>> change-id: 20240601-md-samples-configfs-946b278a9d47
>>
> 
> I don't see this in linux-next yet so following up to see if anything else is
> needed to get this merged.

I still don't see this in linux-next so adding Andrew & Greg to see if this
should go through one of their misc trees. Hoping to have these cleaned up
tree-wide in 6.11.

/jeff

On Tue, Jul 09, 2024 at 03:20:56PM -0700, Jeff Johnson wrote:
> On 6/20/2024 9:46 AM, Jeff Johnson wrote:
> > On 6/1/2024 5:12 PM, Jeff Johnson wrote:
> >> make allmodconfig && make W=1 C=1 reports:
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/configfs/configfs_sample.o
> >>
> >> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> >> ---
> >>  samples/configfs/configfs_sample.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
> >> index 37a657b25d58..fd5d163828c5 100644
> >> --- a/samples/configfs/configfs_sample.c
> >> +++ b/samples/configfs/configfs_sample.c
> >> @@ -364,4 +364,5 @@ static void __exit configfs_example_exit(void)
> >>  
> >>  module_init(configfs_example_init);
> >>  module_exit(configfs_example_exit);
> >> +MODULE_DESCRIPTION("Sample configfs module");
> >>  MODULE_LICENSE("GPL");
> >>
> >> ---
> >> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> >> change-id: 20240601-md-samples-configfs-946b278a9d47
> >>
> > 
> > I don't see this in linux-next yet so following up to see if anything else is
> > needed to get this merged.
> 
> I still don't see this in linux-next so adding Andrew & Greg to see if this
> should go through one of their misc trees. Hoping to have these cleaned up
> tree-wide in 6.11.

I'll take it, thanks.

greg k-h

Hi don't get what the freaking point is.  It's not like
MODULE_DESCRIPTION is useful in any way, so adding pointless boilerplate
like this is:

Nacked-by: Christoph Hellwig <hch@lst.de>

until we can come up with a really good reason for it.