RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

[PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by linux@treblig.org 1 year, 8 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'rds_ib_dereg_odp_mr' has been unused since the original
commit 2eafa1746f17 ("net/rds: Handle ODP mr
registration/unregistration").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 net/rds/ib_rdma.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
index 8f070ee7e742..d1cfceeff133 100644
--- a/net/rds/ib_rdma.c
+++ b/net/rds/ib_rdma.c
@@ -40,10 +40,6 @@
 #include "rds.h"
 
 struct workqueue_struct *rds_ib_mr_wq;
-struct rds_ib_dereg_odp_mr {
-	struct work_struct work;
-	struct ib_mr *mr;
-};
 
 static void rds_ib_odp_mr_worker(struct work_struct *work);
 
-- 
2.45.1

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Zhu Yanjun 1 year, 6 months ago

在 2024/6/1 1:33, linux@treblig.org 写道:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
> 
> Remove it.
> 
Need Fixes?

Fixes: 2eafa1746f17 ("net/rds: Handle ODP mr
registration/unregistration")

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Zhu Yanjun
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   net/rds/ib_rdma.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..d1cfceeff133 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -40,10 +40,6 @@
>   #include "rds.h"
>   
>   struct workqueue_struct *rds_ib_mr_wq;
> -struct rds_ib_dereg_odp_mr {
> -	struct work_struct work;
> -	struct ib_mr *mr;
> -};
>   
>   static void rds_ib_odp_mr_worker(struct work_struct *work);
>

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* Zhu Yanjun (yanjun.zhu@linux.dev) wrote:
> 在 2024/6/1 1:33, linux@treblig.org 写道:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> > 
> > Remove it.
> > 
> Need Fixes?
> 
> Fixes: 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration")

I've not been using Fixes on these, because they
have no actual consequence - there's no need
for stable or downstream to pick them up, which is
what Fixes is often used for.

> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Thanks,

Dave

> Zhu Yanjun
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >   net/rds/ib_rdma.c | 4 ----
> >   1 file changed, 4 deletions(-)
> > 
> > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> > index 8f070ee7e742..d1cfceeff133 100644
> > --- a/net/rds/ib_rdma.c
> > +++ b/net/rds/ib_rdma.c
> > @@ -40,10 +40,6 @@
> >   #include "rds.h"
> >   struct workqueue_struct *rds_ib_mr_wq;
> > -struct rds_ib_dereg_odp_mr {
> > -	struct work_struct work;
> > -	struct ib_mr *mr;
> > -};
> >   static void rds_ib_odp_mr_worker(struct work_struct *work);
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Allison Henderson 1 year, 8 months ago

On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

This patch looks fine to me, the struct is indeed unused at this point.
Thanks for the clean up!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>  net/rds/ib_rdma.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..d1cfceeff133 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -40,10 +40,6 @@
>  #include "rds.h"
>  
>  struct workqueue_struct *rds_ib_mr_wq;
> -struct rds_ib_dereg_odp_mr {
> -       struct work_struct work;
> -       struct ib_mr *mr;
> -};
>  
>  static void rds_ib_odp_mr_worker(struct work_struct *work);
>

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* Allison Henderson (allison.henderson@oracle.com) wrote:
> On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> This patch looks fine to me, the struct is indeed unused at this point.
> Thanks for the clean up!
> 
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

Hi,
  Does anyone know who might pick this one up - I don't think
it's in -next yet?

Dave

> > ---
> >  net/rds/ib_rdma.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> > index 8f070ee7e742..d1cfceeff133 100644
> > --- a/net/rds/ib_rdma.c
> > +++ b/net/rds/ib_rdma.c
> > @@ -40,10 +40,6 @@
> >  #include "rds.h"
> >  
> >  struct workqueue_struct *rds_ib_mr_wq;
> > -struct rds_ib_dereg_odp_mr {
> > -       struct work_struct work;
> > -       struct ib_mr *mr;
> > -};
> >  
> >  static void rds_ib_odp_mr_worker(struct work_struct *work);
> >  
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Leon Romanovsky 1 year, 6 months ago

On Sat, Jul 20, 2024 at 12:28:17AM +0000, Dr. David Alan Gilbert wrote:
> * Allison Henderson (allison.henderson@oracle.com) wrote:
> > On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > 'rds_ib_dereg_odp_mr' has been unused since the original
> > > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > > registration/unregistration").
> > > 
> > > Remove it.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > This patch looks fine to me, the struct is indeed unused at this point.
> > Thanks for the clean up!
> > 
> > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> 
> Hi,
>   Does anyone know who might pick this one up - I don't think
> it's in -next yet?

1. We are in merge window and this patch is not a bug fix, so it should
   wait until the next merge window.
2. Title should be net/rds ... and not RDMA/rds ...
3. netdev is closed right now, so it should be resubmitted after next merge
   window ends.

Thanks

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* Leon Romanovsky (leon@kernel.org) wrote:
> On Sat, Jul 20, 2024 at 12:28:17AM +0000, Dr. David Alan Gilbert wrote:
> > * Allison Henderson (allison.henderson@oracle.com) wrote:
> > > On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > 
> > > > 'rds_ib_dereg_odp_mr' has been unused since the original
> > > > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > > > registration/unregistration").
> > > > 
> > > > Remove it.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > 
> > > This patch looks fine to me, the struct is indeed unused at this point.
> > > Thanks for the clean up!
> > > 
> > > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> > 
> > Hi,
> >   Does anyone know who might pick this one up - I don't think
> > it's in -next yet?
> 
> 1. We are in merge window and this patch is not a bug fix, so it should
>    wait until the next merge window.

Yeh I did wonder; it was posted and reviewed back at the start of June.

> 2. Title should be net/rds ... and not RDMA/rds ...

OK, I can easily fix that.

> 3. netdev is closed right now, so it should be resubmitted after next merge
>    window ends.

When you say 'resubmitted' - you mean reposted to the lists with the amended
title? Or what?

Dave

> Thanks
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Leon Romanovsky 1 year, 6 months ago

On Sun, Jul 21, 2024 at 11:02:49AM +0000, Dr. David Alan Gilbert wrote:
> * Leon Romanovsky (leon@kernel.org) wrote:
> > On Sat, Jul 20, 2024 at 12:28:17AM +0000, Dr. David Alan Gilbert wrote:
> > > * Allison Henderson (allison.henderson@oracle.com) wrote:
> > > > On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > > 
> > > > > 'rds_ib_dereg_odp_mr' has been unused since the original
> > > > > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > > > > registration/unregistration").
> > > > > 
> > > > > Remove it.
> > > > > 
> > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > > 
> > > > This patch looks fine to me, the struct is indeed unused at this point.
> > > > Thanks for the clean up!
> > > > 
> > > > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> > > 
> > > Hi,
> > >   Does anyone know who might pick this one up - I don't think
> > > it's in -next yet?
> > 
> > 1. We are in merge window and this patch is not a bug fix, so it should
> >    wait until the next merge window.
> 
> Yeh I did wonder; it was posted and reviewed back at the start of June.
> 
> > 2. Title should be net/rds ... and not RDMA/rds ...
> 
> OK, I can easily fix that.
> 
> > 3. netdev is closed right now, so it should be resubmitted after next merge
> >    window ends.
> 
> When you say 'resubmitted' - you mean reposted to the lists with the amended
> title? Or what?

Yes, reposted to the netdev@ ML with the correct title.

Thanks

> 
> Dave
> 
> > Thanks
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* Leon Romanovsky (leon@kernel.org) wrote:
> On Sun, Jul 21, 2024 at 11:02:49AM +0000, Dr. David Alan Gilbert wrote:
> > * Leon Romanovsky (leon@kernel.org) wrote:
> > > On Sat, Jul 20, 2024 at 12:28:17AM +0000, Dr. David Alan Gilbert wrote:
> > > > * Allison Henderson (allison.henderson@oracle.com) wrote:
> > > > > On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> > > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > > > 
> > > > > > 'rds_ib_dereg_odp_mr' has been unused since the original
> > > > > > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > > > > > registration/unregistration").
> > > > > > 
> > > > > > Remove it.
> > > > > > 
> > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > > > 
> > > > > This patch looks fine to me, the struct is indeed unused at this point.
> > > > > Thanks for the clean up!
> > > > > 
> > > > > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> > > > 
> > > > Hi,
> > > >   Does anyone know who might pick this one up - I don't think
> > > > it's in -next yet?
> > > 
> > > 1. We are in merge window and this patch is not a bug fix, so it should
> > >    wait until the next merge window.
> > 
> > Yeh I did wonder; it was posted and reviewed back at the start of June.
> > 
> > > 2. Title should be net/rds ... and not RDMA/rds ...
> > 
> > OK, I can easily fix that.
> > 
> > > 3. netdev is closed right now, so it should be resubmitted after next merge
> > >    window ends.
> > 
> > When you say 'resubmitted' - you mean reposted to the lists with the amended
> > title? Or what?
> 
> Yes, reposted to the netdev@ ML with the correct title.

OK, reposted as
Message-ID: 20240729210114.48522-1-linux@treblig.org

Dave

> Thanks
> 
> > 
> > Dave
> > 
> > > Thanks
> > > 
> > -- 
> >  -----Open up your eyes, open up your mind, open up your code -------   
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Simon Horman 1 year, 8 months ago

On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").

nit: Maybe commit lines are best not line-wrapped.
     I'm unsure.

> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

The above not withstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Posted by Dr. David Alan Gilbert 1 year, 8 months ago

* Simon Horman (horms@kernel.org) wrote:
> On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> 
> nit: Maybe commit lines are best not line-wrapped.
>      I'm unsure.

Yeh I wasn't too sure, checkpatch seems to have code
to deal with it, so it is expecting it could be wrapped:

  # A commit match can span multiple lines so this block attempts to find a
  # complete typical commit on a maximum of 3 lines

> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> The above not withstanding, this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Thanks!

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/