[PATCH] net: caif: remove unused structs

linux@treblig.org posted 1 patch 1 year, 8 months ago
include/net/caif/caif_layer.h | 2 --
net/caif/cfpkt_skbuff.c       | 7 -------
2 files changed, 9 deletions(-)
[PATCH] net: caif: remove unused structs
Posted by linux@treblig.org 1 year, 8 months ago
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'cfpktq' has been unused since
commit 73d6ac633c6c ("caif: code cleanup").

'caif_packet_funcs' is declared but never defined.

Remove both of them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/net/caif/caif_layer.h | 2 --
 net/caif/cfpkt_skbuff.c       | 7 -------
 2 files changed, 9 deletions(-)

diff --git a/include/net/caif/caif_layer.h b/include/net/caif/caif_layer.h
index 51f7bb42a936..0f45d875905f 100644
--- a/include/net/caif/caif_layer.h
+++ b/include/net/caif/caif_layer.h
@@ -11,9 +11,7 @@
 
 struct cflayer;
 struct cfpkt;
-struct cfpktq;
 struct caif_payload_info;
-struct caif_packet_funcs;
 
 #define CAIF_LAYER_NAME_SZ 16
 
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 7796414d47e5..2ae8cfa3df88 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -21,13 +21,6 @@ do {					   \
 	pr_warn(errmsg);		   \
 } while (0)
 
-struct cfpktq {
-	struct sk_buff_head head;
-	atomic_t count;
-	/* Lock protects count updates */
-	spinlock_t lock;
-};
-
 /*
  * net/caif/ is generic and does not
  * understand SKB, so we do this typecast
-- 
2.45.1
Re: [PATCH] net: caif: remove unused structs
Posted by Jacob Keller 1 year, 8 months ago

On 5/31/2024 4:29 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cfpktq' has been unused since
> commit 73d6ac633c6c ("caif: code cleanup").
> 
> 'caif_packet_funcs' is declared but never defined.
> 
> Remove both of them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>