lm3533: Remove the outdated drivers

[PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Andy Shevchenko 1 year, 8 months ago

Driver is quite outdated from the Linux kernel internal APIs
perspective. In particular GPIO code is using legacy calls,
that started being replaced by a new API ca. 2014, i.e. ten
years ago.

Suggested-by: Linus Walleij <linus.walleij@linaro.org>

Andy Shevchenko (4):
  backlight: lm3533_bl: Remove the driver
  iio: light: lm3533-als: Remove the driver
  leds: lm3533: Remove the driver
  mfd: lm3533: Remove the driver

 drivers/iio/light/Kconfig           |  17 -
 drivers/iio/light/Makefile          |   1 -
 drivers/iio/light/lm3533-als.c      | 922 ----------------------------
 drivers/leds/Kconfig                |  13 -
 drivers/leds/Makefile               |   1 -
 drivers/leds/leds-lm3533.c          | 755 -----------------------
 drivers/mfd/lm3533-core.c           | 645 -------------------
 drivers/video/backlight/Kconfig     |  11 -
 drivers/video/backlight/Makefile    |   1 -
 drivers/video/backlight/lm3533_bl.c | 399 ------------
 include/linux/mfd/lm3533.h          | 100 ---
 11 files changed, 2865 deletions(-)
 delete mode 100644 drivers/iio/light/lm3533-als.c
 delete mode 100644 drivers/leds/leds-lm3533.c
 delete mode 100644 drivers/mfd/lm3533-core.c
 delete mode 100644 drivers/video/backlight/lm3533_bl.c
 delete mode 100644 include/linux/mfd/lm3533.h

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Andy Shevchenko 1 year, 8 months ago

On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> Driver is quite outdated from the Linux kernel internal APIs
> perspective. In particular GPIO code is using legacy calls,
> that started being replaced by a new API ca. 2014, i.e. ten
> years ago.
> 
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>

>  drivers/mfd/lm3533-core.c           | 645 -------------------

Oops, still leftovers: one file and Kconfig/Makefile updates...
If needed I'll send a v2, but now I leave it to Lee and Johan to decide
the destiny of the drivers.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Andy Shevchenko 1 year, 8 months ago

+Cc: Johan (via kernel.org)

On Fri, May 31, 2024 at 08:14:43PM +0300, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > Driver is quite outdated from the Linux kernel internal APIs
> > perspective. In particular GPIO code is using legacy calls,
> > that started being replaced by a new API ca. 2014, i.e. ten
> > years ago.
> > 
> > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> 
> >  drivers/mfd/lm3533-core.c           | 645 -------------------
> 
> Oops, still leftovers: one file and Kconfig/Makefile updates...
> If needed I'll send a v2, but now I leave it to Lee and Johan to decide
> the destiny of the drivers.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Johan Hovold 1 year, 8 months ago

On Fri, May 31, 2024 at 08:17:34PM +0300, Andy Shevchenko wrote:
> +Cc: Johan (via kernel.org)
> 
> On Fri, May 31, 2024 at 08:14:43PM +0300, Andy Shevchenko wrote:
> > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > > Driver is quite outdated from the Linux kernel internal APIs
> > > perspective. In particular GPIO code is using legacy calls,
> > > that started being replaced by a new API ca. 2014, i.e. ten
> > > years ago.
> > > 
> > > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > >  drivers/mfd/lm3533-core.c           | 645 -------------------
> > 
> > Oops, still leftovers: one file and Kconfig/Makefile updates...
> > If needed I'll send a v2, but now I leave it to Lee and Johan to decide
> > the destiny of the drivers.

I prefer to keep them as I just mentioned here:

	https://lore.kernel.org/lkml/ZmBcvtLCzllQDWVX@hovoldconsulting.com/

Johan

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Lee Jones 1 year, 8 months ago

On Fri, 31 May 2024, Andy Shevchenko wrote:

> On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > Driver is quite outdated from the Linux kernel internal APIs
> > perspective. In particular GPIO code is using legacy calls,
> > that started being replaced by a new API ca. 2014, i.e. ten
> > years ago.
> > 
> > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> 
> >  drivers/mfd/lm3533-core.c           | 645 -------------------
> 
> Oops, still leftovers: one file and Kconfig/Makefile updates...
> If needed I'll send a v2, but now I leave it to Lee and Johan to decide
> the destiny of the drivers.

Let's not rush into it.  Take your time.

-- 
Lee Jones [李琼斯]

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Andy Shevchenko 1 year, 8 months ago

On Fri, May 31, 2024 at 06:15:46PM +0100, Lee Jones wrote:
> On Fri, 31 May 2024, Andy Shevchenko wrote:
> > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > > Driver is quite outdated from the Linux kernel internal APIs
> > > perspective. In particular GPIO code is using legacy calls,
> > > that started being replaced by a new API ca. 2014, i.e. ten
> > > years ago.
> > > 
> > > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > >  drivers/mfd/lm3533-core.c           | 645 -------------------
> > 
> > Oops, still leftovers: one file and Kconfig/Makefile updates...
> > If needed I'll send a v2, but now I leave it to Lee and Johan to decide
> > the destiny of the drivers.
> 
> Let's not rush into it.  Take your time.

Exactly, excellente fin de semaine!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Lee Jones 1 year, 8 months ago

Making sure Johan is aware of this with his new address.

On Fri, 31 May 2024, Andy Shevchenko wrote:

> Driver is quite outdated from the Linux kernel internal APIs
> perspective. In particular GPIO code is using legacy calls,
> that started being replaced by a new API ca. 2014, i.e. ten
> years ago.
> 
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Andy Shevchenko (4):
>   backlight: lm3533_bl: Remove the driver
>   iio: light: lm3533-als: Remove the driver
>   leds: lm3533: Remove the driver
>   mfd: lm3533: Remove the driver
> 
>  drivers/iio/light/Kconfig           |  17 -
>  drivers/iio/light/Makefile          |   1 -
>  drivers/iio/light/lm3533-als.c      | 922 ----------------------------
>  drivers/leds/Kconfig                |  13 -
>  drivers/leds/Makefile               |   1 -
>  drivers/leds/leds-lm3533.c          | 755 -----------------------
>  drivers/mfd/lm3533-core.c           | 645 -------------------
>  drivers/video/backlight/Kconfig     |  11 -
>  drivers/video/backlight/Makefile    |   1 -
>  drivers/video/backlight/lm3533_bl.c | 399 ------------
>  include/linux/mfd/lm3533.h          | 100 ---
>  11 files changed, 2865 deletions(-)
>  delete mode 100644 drivers/iio/light/lm3533-als.c
>  delete mode 100644 drivers/leds/leds-lm3533.c
>  delete mode 100644 drivers/mfd/lm3533-core.c
>  delete mode 100644 drivers/video/backlight/lm3533_bl.c
>  delete mode 100644 include/linux/mfd/lm3533.h
> 
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 

-- 
Lee Jones [李琼斯]

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

Posted by Andy Shevchenko 1 year, 8 months ago

On Fri, May 31, 2024 at 06:14:25PM +0100, Lee Jones wrote:
> Making sure Johan is aware of this with his new address.

Right, in any case this is not the final version (a couple of leftovers).
I have mentioned this series in the original thread.

-- 
With Best Regards,
Andy Shevchenko