list: test: remove unused struct 'klist_test_struct'

[PATCH] list: test: remove unused struct 'klist_test_struct'

Posted by linux@treblig.org 1 year, 8 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'klist_test_struct' has been unused since the original
commit 57b4f760f94d ("list: test: Test the klist structure").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 lib/list-test.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/list-test.c b/lib/list-test.c
index 0cc27de9cec8..383ee0ad582e 100644
--- a/lib/list-test.c
+++ b/lib/list-test.c
@@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
 };
 
 
-struct klist_test_struct {
-	int data;
-	struct klist klist;
-	struct klist_node klist_node;
-};
-
 static int node_count;
 static struct klist_node *last_node;
 
-- 
2.45.1

Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

Posted by David Gow 1 year, 8 months ago

On Fri, 31 May 2024 at 23:18, <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'klist_test_struct' has been unused since the original
> commit 57b4f760f94d ("list: test: Test the klist structure").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---

Nice catch, thanks! That's what I get for copy-patste, I guess! :-)

(I agree that this is better without the Fixes tag, too.)

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  lib/list-test.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..383ee0ad582e 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
>  };
>
>
> -struct klist_test_struct {
> -       int data;
> -       struct klist klist;
> -       struct klist_node klist_node;
> -};
> -
>  static int node_count;
>  static struct klist_node *last_node;
>
> --
> 2.45.1
>

Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

Posted by Muhammad Usama Anjum 1 year, 8 months ago

On 5/31/24 8:18 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'klist_test_struct' has been unused since the original
> commit 57b4f760f94d ("list: test: Test the klist structure").
Probably a fixes by tag would be needed here.

> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  lib/list-test.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..383ee0ad582e 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
>  };
>  
>  
> -struct klist_test_struct {
> -	int data;
> -	struct klist klist;
> -	struct klist_node klist_node;
> -};
> -
>  static int node_count;
>  static struct klist_node *last_node;
>  

-- 
BR,
Muhammad Usama Anjum

Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

Posted by Dr. David Alan Gilbert 1 year, 8 months ago

* Muhammad Usama Anjum (usama.anjum@collabora.com) wrote:
> On 5/31/24 8:18 PM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'klist_test_struct' has been unused since the original
> > commit 57b4f760f94d ("list: test: Test the klist structure").
> Probably a fixes by tag would be needed here.

I'm generally avoiding fixes tags in this set of changes, since
  a) They have no behavioural change at all.
  b) Downstream and stable kernel people use fixes tags to indicate
     stuff they should pick up if they have the original, and there's
     no need for them to do that with this cleanup.

Dave

> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  lib/list-test.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/lib/list-test.c b/lib/list-test.c
> > index 0cc27de9cec8..383ee0ad582e 100644
> > --- a/lib/list-test.c
> > +++ b/lib/list-test.c
> > @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
> >  };
> >  
> >  
> > -struct klist_test_struct {
> > -	int data;
> > -	struct klist klist;
> > -	struct klist_node klist_node;
> > -};
> > -
> >  static int node_count;
> >  static struct klist_node *last_node;
> >  
> 
> -- 
> BR,
> Muhammad Usama Anjum
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

Posted by Shuah Khan 1 year, 8 months ago

On 5/31/24 12:58, Dr. David Alan Gilbert wrote:
> * Muhammad Usama Anjum (usama.anjum@collabora.com) wrote:
>> On 5/31/24 8:18 PM, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'klist_test_struct' has been unused since the original
>>> commit 57b4f760f94d ("list: test: Test the klist structure").
>> Probably a fixes by tag would be needed here.
> 
> I'm generally avoiding fixes tags in this set of changes, since
>    a) They have no behavioural change at all.
>    b) Downstream and stable kernel people use fixes tags to indicate
>       stuff they should pick up if they have the original, and there's
>       no need for them to do that with this cleanup.
> 
> Dave

+1 on using careful use of Fixes tag only on real fixes for the
reasons mentioned above.

thanks,
-- Shuah