NFSD: remove unused structs 'nfsd3_voidargs'

[PATCH] NFSD: remove unused structs 'nfsd3_voidargs'

Posted by linux@treblig.org 1 year, 6 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'nfsd3_voidargs' in nfs[23]acl.c is unused since
commit 788f7183fba8 ("NFSD: Add common helpers to decode void args and
encode void results").

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 fs/nfsd/nfs2acl.c | 2 --
 fs/nfsd/nfs3acl.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
index 12b2b9bc07bf..4e3be7201b1c 100644
--- a/fs/nfsd/nfs2acl.c
+++ b/fs/nfsd/nfs2acl.c
@@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct svc_rqst *rqstp)
 	fh_put(&resp->fh);
 }
 
-struct nfsd3_voidargs { int dummy; };
-
 #define ST 1		/* status*/
 #define AT 21		/* attributes */
 #define pAT (1+AT)	/* post attributes - conditional */
diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
index 73adca47d373..5e34e98db969 100644
--- a/fs/nfsd/nfs3acl.c
+++ b/fs/nfsd/nfs3acl.c
@@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct svc_rqst *rqstp)
 	posix_acl_release(resp->acl_default);
 }
 
-struct nfsd3_voidargs { int dummy; };
-
 #define ST 1		/* status*/
 #define AT 21		/* attributes */
 #define pAT (1+AT)	/* post attributes - conditional */
-- 
2.45.1

Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'

Posted by Chuck Lever 1 year, 6 months ago

On Thu, May 30, 2024 at 08:08:38PM -0400, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args and
> encode void results").
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  fs/nfsd/nfs2acl.c | 2 --
>  fs/nfsd/nfs3acl.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct svc_rqst *rqstp)
>  	fh_put(&resp->fh);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct svc_rqst *rqstp)
>  	posix_acl_release(resp->acl_default);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> -- 
> 2.45.1
> 

Applied to nfsd-next (for v6.11). Thank you!

-- 
Chuck Lever

Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'

Posted by Jeff Layton 1 year, 6 months ago

On Fri, 2024-05-31 at 01:08 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args
> and
> encode void results").
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  fs/nfsd/nfs2acl.c | 2 --
>  fs/nfsd/nfs3acl.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct
> svc_rqst *rqstp)
>  	fh_put(&resp->fh);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct
> svc_rqst *rqstp)
>  	posix_acl_release(resp->acl_default);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */

Reviewed-by: Jeff Layton <jlayton@kernel.org>