cdx: remove unused struct 'cdx_mcdi_copy_buffer'

[PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by linux@treblig.org 1 year, 6 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'cdx_mcdi_copy_buffer' has been unused since the original
commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
interaction").

Looking at lkml,  it was used in the V1 posting but was removed
somewhere before V6.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/cdx/controller/mcdi.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
index 1eedc5eeb315..e760f8d347cc 100644
--- a/drivers/cdx/controller/mcdi.c
+++ b/drivers/cdx/controller/mcdi.c
@@ -27,10 +27,6 @@
 #include "bitfield.h"
 #include "mcdi.h"
 
-struct cdx_mcdi_copy_buffer {
-	struct cdx_dword buffer[DIV_ROUND_UP(MCDI_CTL_SDU_LEN_MAX, 4)];
-};
-
 static void cdx_mcdi_cancel_cmd(struct cdx_mcdi *cdx, struct cdx_mcdi_cmd *cmd);
 static void cdx_mcdi_wait_for_cleanup(struct cdx_mcdi *cdx);
 static int cdx_mcdi_rpc_async_internal(struct cdx_mcdi *cdx,
-- 
2.45.1

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Gupta, Nipun 1 year, 6 months ago


On 5/31/2024 5:04 AM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cdx_mcdi_copy_buffer' has been unused since the original
> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction").
> 
> Looking at lkml,  it was used in the V1 posting but was removed
> somewhere before V6.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Acked-by: Nipun Gupta <nipun.gupta@amd.com>

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Dr. David Alan Gilbert 1 year, 4 months ago

* Gupta, Nipun (nipun.gupta@amd.com) wrote:
> 
> 
> On 5/31/2024 5:04 AM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'cdx_mcdi_copy_buffer' has been unused since the original
> > commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> > interaction").
> > 
> > Looking at lkml,  it was used in the V1 posting but was removed
> > somewhere before V6.
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> Acked-by: Nipun Gupta <nipun.gupta@amd.com>

Hi Nipun,
  Do you know who would pick this one up? I don't think it's made it's
way into -next yet.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Gupta, Nipun 1 year, 4 months ago

On 7/22/2024 4:17 AM, Dr. David Alan Gilbert wrote:
> * Gupta, Nipun (nipun.gupta@amd.com) wrote:
>>
>>
>> On 5/31/2024 5:04 AM, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'cdx_mcdi_copy_buffer' has been unused since the original
>>> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
>>> interaction").
>>>
>>> Looking at lkml,  it was used in the V1 posting but was removed
>>> somewhere before V6.
>>>
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>> Acked-by: Nipun Gupta <nipun.gupta@amd.com>
> 
> Hi Nipun,
>    Do you know who would pick this one up? I don't think it's made it's
> way into -next yet.

Added Greg k-h for this.

> 
> Dave
>

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Greg KH 1 year, 4 months ago

On Mon, Jul 22, 2024 at 09:59:27AM +0530, Gupta, Nipun wrote:
> On 7/22/2024 4:17 AM, Dr. David Alan Gilbert wrote:
> > * Gupta, Nipun (nipun.gupta@amd.com) wrote:
> > > 
> > > 
> > > On 5/31/2024 5:04 AM, linux@treblig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > 
> > > > 'cdx_mcdi_copy_buffer' has been unused since the original
> > > > commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> > > > interaction").
> > > > 
> > > > Looking at lkml,  it was used in the V1 posting but was removed
> > > > somewhere before V6.
> > > > 
> > > > Remove it.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > Acked-by: Nipun Gupta <nipun.gupta@amd.com>
> > 
> > Hi Nipun,
> >    Do you know who would pick this one up? I don't think it's made it's
> > way into -next yet.
> 
> Added Greg k-h for this.

For what?  Sorry, I have no context here...

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Gupta, Nipun 1 year, 4 months ago


On 7/22/2024 10:16 AM, Greg KH wrote:
> On Mon, Jul 22, 2024 at 09:59:27AM +0530, Gupta, Nipun wrote:
>> On 7/22/2024 4:17 AM, Dr. David Alan Gilbert wrote:
>>> * Gupta, Nipun (nipun.gupta@amd.com) wrote:
>>>>
>>>>
>>>> On 5/31/2024 5:04 AM, linux@treblig.org wrote:
>>>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>>>
>>>>> 'cdx_mcdi_copy_buffer' has been unused since the original
>>>>> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
>>>>> interaction").
>>>>>
>>>>> Looking at lkml,  it was used in the V1 posting but was removed
>>>>> somewhere before V6.
>>>>>
>>>>> Remove it.
>>>>>
>>>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>>> Acked-by: Nipun Gupta <nipun.gupta@amd.com>
>>>
>>> Hi Nipun,
>>>     Do you know who would pick this one up? I don't think it's made it's
>>> way into -next yet.
>>
>> Added Greg k-h for this.
> 
> For what?  Sorry, I have no context here...

This patch is from David to remove an unused structure in CDX. He is 
asking me that who will pick this up to be added in linux code. So I 
just added you explicitly, as you will be adding it in the your branch 
which will go in linux-next :)

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Greg KH 1 year, 4 months ago

On Mon, Jul 22, 2024 at 10:57:46AM +0530, Gupta, Nipun wrote:
> 
> 
> On 7/22/2024 10:16 AM, Greg KH wrote:
> > On Mon, Jul 22, 2024 at 09:59:27AM +0530, Gupta, Nipun wrote:
> > > On 7/22/2024 4:17 AM, Dr. David Alan Gilbert wrote:
> > > > * Gupta, Nipun (nipun.gupta@amd.com) wrote:
> > > > > 
> > > > > 
> > > > > On 5/31/2024 5:04 AM, linux@treblig.org wrote:
> > > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > > > 
> > > > > > 'cdx_mcdi_copy_buffer' has been unused since the original
> > > > > > commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> > > > > > interaction").
> > > > > > 
> > > > > > Looking at lkml,  it was used in the V1 posting but was removed
> > > > > > somewhere before V6.
> > > > > > 
> > > > > > Remove it.
> > > > > > 
> > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > > > Acked-by: Nipun Gupta <nipun.gupta@amd.com>
> > > > 
> > > > Hi Nipun,
> > > >     Do you know who would pick this one up? I don't think it's made it's
> > > > way into -next yet.
> > > 
> > > Added Greg k-h for this.
> > 
> > For what?  Sorry, I have no context here...
> 
> This patch is from David to remove an unused structure in CDX. He is asking
> me that who will pick this up to be added in linux code. So I just added you
> explicitly, as you will be adding it in the your branch which will go in
> linux-next :)

Sorry, please wait for -rc1 to come out, it's the middle of the merge
window right now and I can't do anything new until then.

thanks,

greg k-h

Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cdx_mcdi_copy_buffer' has been unused since the original
> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction").
> 
> Looking at lkml,  it was used in the V1 posting but was removed
> somewhere before V6.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.

Dave

> ---
>  drivers/cdx/controller/mcdi.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
> index 1eedc5eeb315..e760f8d347cc 100644
> --- a/drivers/cdx/controller/mcdi.c
> +++ b/drivers/cdx/controller/mcdi.c
> @@ -27,10 +27,6 @@
>  #include "bitfield.h"
>  #include "mcdi.h"
>  
> -struct cdx_mcdi_copy_buffer {
> -	struct cdx_dword buffer[DIV_ROUND_UP(MCDI_CTL_SDU_LEN_MAX, 4)];
> -};
> -
>  static void cdx_mcdi_cancel_cmd(struct cdx_mcdi *cdx, struct cdx_mcdi_cmd *cmd);
>  static void cdx_mcdi_wait_for_cleanup(struct cdx_mcdi *cdx);
>  static int cdx_mcdi_rpc_async_internal(struct cdx_mcdi *cdx,
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/