[v1] nvme-apple: add missing MODULE_DESCRIPTION()

[PATCH] nvme-apple: add missing MODULE_DESCRIPTION()

Posted by Jeff Johnson 1 year, 8 months ago

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-apple.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/nvme/host/apple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
index dd6ec0865141..0cfa39361d3b 100644
--- a/drivers/nvme/host/apple.c
+++ b/drivers/nvme/host/apple.c
@@ -1602,4 +1602,5 @@ static struct platform_driver apple_nvme_driver = {
 module_platform_driver(apple_nvme_driver);
 
 MODULE_AUTHOR("Sven Peter <sven@svenpeter.dev>");
+MODULE_DESCRIPTION("Apple ANS NVM Express device driver");
 MODULE_LICENSE("GPL");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240530-md-nvme-apple-e0edb9b98c45

Re: [PATCH] nvme-apple: add missing MODULE_DESCRIPTION()

Posted by Eric Curtin 1 year, 8 months ago

On Fri, 31 May 2024 at 06:25, Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-apple.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Eric Curtin <ecurtin@redhat.com>

Is mise le meas/Regards,

Eric Curtin

> ---
>  drivers/nvme/host/apple.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
> index dd6ec0865141..0cfa39361d3b 100644
> --- a/drivers/nvme/host/apple.c
> +++ b/drivers/nvme/host/apple.c
> @@ -1602,4 +1602,5 @@ static struct platform_driver apple_nvme_driver = {
>  module_platform_driver(apple_nvme_driver);
>
>  MODULE_AUTHOR("Sven Peter <sven@svenpeter.dev>");
> +MODULE_DESCRIPTION("Apple ANS NVM Express device driver");
>  MODULE_LICENSE("GPL");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-md-nvme-apple-e0edb9b98c45
>
>

Re: [PATCH] nvme-apple: add missing MODULE_DESCRIPTION()

Posted by Sven Peter 1 year, 8 months ago

> On 31. May 2024, at 07:16, Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> 
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-apple.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Sven Peter <sven@svenpeter.dev>

Re: [PATCH] nvme-apple: add missing MODULE_DESCRIPTION()

Posted by Sagi Grimberg 1 year, 8 months ago

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>