kcsan: test: add missing MODULE_DESCRIPTION() macro

[PATCH] kcsan: test: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 6 months ago

Fix the warning reported by 'make C=1 W=1':
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/kcsan/kcsan_test.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 kernel/kcsan/kcsan_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c
index 0c17b4c83e1c..117d9d4d3c3b 100644
--- a/kernel/kcsan/kcsan_test.c
+++ b/kernel/kcsan/kcsan_test.c
@@ -1620,5 +1620,6 @@ static struct kunit_suite kcsan_test_suite = {
 
 kunit_test_suites(&kcsan_test_suite);
 
+MODULE_DESCRIPTION("KCSAN test suite");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Marco Elver <elver@google.com>");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240530-md-kernel-kcsan-9795c9551d3b

Re: [PATCH] kcsan: test: add missing MODULE_DESCRIPTION() macro

Posted by Marco Elver 1 year, 6 months ago

On Thu, 30 May 2024 at 21:39, Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> Fix the warning reported by 'make C=1 W=1':
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/kcsan/kcsan_test.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Marco Elver <elver@google.com>

Jeff, do you have a tree to take this through?
If not - Paul, could this go through your tree again?

Many thanks,
-- Marco


> ---
>  kernel/kcsan/kcsan_test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c
> index 0c17b4c83e1c..117d9d4d3c3b 100644
> --- a/kernel/kcsan/kcsan_test.c
> +++ b/kernel/kcsan/kcsan_test.c
> @@ -1620,5 +1620,6 @@ static struct kunit_suite kcsan_test_suite = {
>
>  kunit_test_suites(&kcsan_test_suite);
>
> +MODULE_DESCRIPTION("KCSAN test suite");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Marco Elver <elver@google.com>");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-md-kernel-kcsan-9795c9551d3b
>

Re: [PATCH] kcsan: test: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 6 months ago

On 5/31/2024 12:47 AM, Marco Elver wrote:
> On Thu, 30 May 2024 at 21:39, Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>>
>> Fix the warning reported by 'make C=1 W=1':
>> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/kcsan/kcsan_test.o
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> Reviewed-by: Marco Elver <elver@google.com>
> 
> Jeff, do you have a tree to take this through?
> If not - Paul, could this go through your tree again?

I don't currently have a tree. Kalle is in the process of relocating the
wireless ath tree so that I can push, but that is still work in progress.

Re: [PATCH] kcsan: test: add missing MODULE_DESCRIPTION() macro

Posted by Paul E. McKenney 1 year, 6 months ago

On Fri, May 31, 2024 at 06:54:03AM -0700, Jeff Johnson wrote:
> On 5/31/2024 12:47 AM, Marco Elver wrote:
> > On Thu, 30 May 2024 at 21:39, Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> >>
> >> Fix the warning reported by 'make C=1 W=1':
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/kcsan/kcsan_test.o
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > 
> > Reviewed-by: Marco Elver <elver@google.com>
> > 
> > Jeff, do you have a tree to take this through?
> > If not - Paul, could this go through your tree again?
> 
> I don't currently have a tree. Kalle is in the process of relocating the
> wireless ath tree so that I can push, but that is still work in progress.

Queued and pushed with Marco's Reviewed-by, thank you both!

							Thanx, Paul