USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

[PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by linux@treblig.org 1 year, 6 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'spcp8x5_usb_ctrl_arg' has been unused since the original
commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/usb/serial/spcp8x5.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 09a972a838ee..6b294bf8bc43 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
 };
 MODULE_DEVICE_TABLE(usb, id_table);
 
-struct spcp8x5_usb_ctrl_arg {
-	u8	type;
-	u8	cmd;
-	u8	cmd_type;
-	u16	value;
-	u16	index;
-	u16	length;
-};
-
-
 /* spcp8x5 spec register define */
 #define MCR_CONTROL_LINE_RTS		0x02
 #define MCR_CONTROL_LINE_DTR		0x01
-- 
2.45.1

Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by Johan Hovold 1 year, 5 months ago

On Thu, May 30, 2024 at 12:47:22AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'spcp8x5_usb_ctrl_arg' has been unused since the original
> commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Now applied, thanks.

Johan

Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by Dr. David Alan Gilbert 1 year, 5 months ago

* Johan Hovold (johan@kernel.org) wrote:
> On Thu, May 30, 2024 at 12:47:22AM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'spcp8x5_usb_ctrl_arg' has been unused since the original
> > commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Now applied, thanks.

Thanks!

Dave

> Johan
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'spcp8x5_usb_ctrl_arg' has been unused since the original
> commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping?

Dave

> ---
>  drivers/usb/serial/spcp8x5.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
> index 09a972a838ee..6b294bf8bc43 100644
> --- a/drivers/usb/serial/spcp8x5.c
> +++ b/drivers/usb/serial/spcp8x5.c
> @@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);
>  
> -struct spcp8x5_usb_ctrl_arg {
> -	u8	type;
> -	u8	cmd;
> -	u8	cmd_type;
> -	u16	value;
> -	u16	index;
> -	u16	length;
> -};
> -
> -
>  /* spcp8x5 spec register define */
>  #define MCR_CONTROL_LINE_RTS		0x02
>  #define MCR_CONTROL_LINE_DTR		0x01
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by Greg KH 1 year, 6 months ago

On Thu, Jun 13, 2024 at 01:28:57PM +0000, Dr. David Alan Gilbert wrote:
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'spcp8x5_usb_ctrl_arg' has been unused since the original
> > commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Ping?

It's only been 2 weeks for a "remove some unused code" type of patch,
which will be gotten to, but realize that people are traveling and the
like...  Give it some time.

In the meantime, why not help review other patches on the list?

thanks,

greg k-h

Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* Greg KH (gregkh@linuxfoundation.org) wrote:
> On Thu, Jun 13, 2024 at 01:28:57PM +0000, Dr. David Alan Gilbert wrote:
> > * linux@treblig.org (linux@treblig.org) wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > 'spcp8x5_usb_ctrl_arg' has been unused since the original
> > > commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> > > 
> > > Remove it.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > Ping?
> 
> It's only been 2 weeks for a "remove some unused code" type of patch,
> which will be gotten to, but realize that people are traveling and the
> like...  Give it some time.

OK, it was only a gentle ping, not a moan; and that seems to have
unstuck a few others in the large set this is part of.

> In the meantime, why not help review other patches on the list?

Sure, I'll keep an eye out for stuff that doesn't require too much
detailed knowledge of any particular subsystem.

Dave

> thanks,
> 
> greg k-h
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/