soc/fsl/qbman: remove unused struct 'cgr_comp'

[PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by linux@treblig.org 1 year, 6 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'cgr_comp' has been unused since
commit 96f413f47677 ("soc/fsl/qbman: fix issue in
qman_delete_cgr_safe()").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/soc/fsl/qbman/qman.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 7e9074519ad2..4dc8aba33d9b 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
 }
 EXPORT_SYMBOL(qman_delete_cgr);
 
-struct cgr_comp {
-	struct qman_cgr *cgr;
-	struct completion completion;
-};
-
 static void qman_delete_cgr_smp_call(void *p)
 {
 	qman_delete_cgr((struct qman_cgr *)p);
-- 
2.45.1

Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by Michael Ellerman 1 year, 4 months ago

On Wed, 29 May 2024 00:11:23 +0100, linux@treblig.org wrote:
> 'cgr_comp' has been unused since
> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> qman_delete_cgr_safe()").
> 
> Remove it.
> 
> 
> [...]

Applied to powerpc/fixes.

[1/1] soc/fsl/qbman: remove unused struct 'cgr_comp'
      https://git.kernel.org/powerpc/c/06ce0af34177a110d6a5cf71f924965b9b230691

cheers

Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by Sean Anderson 1 year, 6 months ago

On 5/28/24 19:11, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cgr_comp' has been unused since
> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> qman_delete_cgr_safe()").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/soc/fsl/qbman/qman.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
> index 7e9074519ad2..4dc8aba33d9b 100644
> --- a/drivers/soc/fsl/qbman/qman.c
> +++ b/drivers/soc/fsl/qbman/qman.c
> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>  }
>  EXPORT_SYMBOL(qman_delete_cgr);
>  
> -struct cgr_comp {
> -	struct qman_cgr *cgr;
> -	struct completion completion;
> -};
> -
>  static void qman_delete_cgr_smp_call(void *p)
>  {
>  	qman_delete_cgr((struct qman_cgr *)p);

Reviewed-by: Sean Anderson <sean.anderson@linux.dev>

Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by Dr. David Alan Gilbert 1 year, 5 months ago

* Sean Anderson (sean.anderson@linux.dev) wrote:
> On 5/28/24 19:11, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'cgr_comp' has been unused since
> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> > qman_delete_cgr_safe()").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/soc/fsl/qbman/qman.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
> > index 7e9074519ad2..4dc8aba33d9b 100644
> > --- a/drivers/soc/fsl/qbman/qman.c
> > +++ b/drivers/soc/fsl/qbman/qman.c
> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
> >  }
> >  EXPORT_SYMBOL(qman_delete_cgr);
> >  
> > -struct cgr_comp {
> > -	struct qman_cgr *cgr;
> > -	struct completion completion;
> > -};
> > -
> >  static void qman_delete_cgr_smp_call(void *p)
> >  {
> >  	qman_delete_cgr((struct qman_cgr *)p);
> 
> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>

Hi Sean,
  Do you know who will pick this one up?
  I got a notification a while ago from a patchwork at
  linuxppc-dev marked 'Handled elsewhere' - but I'm not
sure where.

Thanks,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by Michael Ellerman 1 year, 4 months ago

"Dr. David Alan Gilbert" <linux@treblig.org> writes:
> * Sean Anderson (sean.anderson@linux.dev) wrote:
>> On 5/28/24 19:11, linux@treblig.org wrote:
>> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
>> > 
>> > 'cgr_comp' has been unused since
>> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>> > qman_delete_cgr_safe()").
>> > 
>> > Remove it.
>> > 
>> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>> > ---
>> >  drivers/soc/fsl/qbman/qman.c | 5 -----
>> >  1 file changed, 5 deletions(-)
>> > 
>> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>> > index 7e9074519ad2..4dc8aba33d9b 100644
>> > --- a/drivers/soc/fsl/qbman/qman.c
>> > +++ b/drivers/soc/fsl/qbman/qman.c
>> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>> >  }
>> >  EXPORT_SYMBOL(qman_delete_cgr);
>> >  
>> > -struct cgr_comp {
>> > -	struct qman_cgr *cgr;
>> > -	struct completion completion;
>> > -};
>> > -
>> >  static void qman_delete_cgr_smp_call(void *p)
>> >  {
>> >  	qman_delete_cgr((struct qman_cgr *)p);
>> 
>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
>
> Hi Sean,
>   Do you know who will pick this one up?
>   I got a notification a while ago from a patchwork at
>   linuxppc-dev marked 'Handled elsewhere' - but I'm not
> sure where.

drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
look after it.

This patch looks trivial so I can just pick it up if you like Christophe?

cheers

Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

Posted by Christophe Leroy 1 year, 4 months ago


Le 22/07/2024 à 09:24, Michael Ellerman a écrit :
> "Dr. David Alan Gilbert" <linux@treblig.org> writes:
>> * Sean Anderson (sean.anderson@linux.dev) wrote:
>>> On 5/28/24 19:11, linux@treblig.org wrote:
>>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>>
>>>> 'cgr_comp' has been unused since
>>>> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>>>> qman_delete_cgr_safe()").
>>>>
>>>> Remove it.
>>>>
>>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>>> ---
>>>>   drivers/soc/fsl/qbman/qman.c | 5 -----
>>>>   1 file changed, 5 deletions(-)
>>>>
>>>> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>>>> index 7e9074519ad2..4dc8aba33d9b 100644
>>>> --- a/drivers/soc/fsl/qbman/qman.c
>>>> +++ b/drivers/soc/fsl/qbman/qman.c
>>>> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>>>>   }
>>>>   EXPORT_SYMBOL(qman_delete_cgr);
>>>>   
>>>> -struct cgr_comp {
>>>> -	struct qman_cgr *cgr;
>>>> -	struct completion completion;
>>>> -};
>>>> -
>>>>   static void qman_delete_cgr_smp_call(void *p)
>>>>   {
>>>>   	qman_delete_cgr((struct qman_cgr *)p);
>>>
>>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
>>
>> Hi Sean,
>>    Do you know who will pick this one up?
>>    I got a notification a while ago from a patchwork at
>>    linuxppc-dev marked 'Handled elsewhere' - but I'm not
>> sure where.
> 
> drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
> look after it.
> 
> This patch looks trivial so I can just pick it up if you like Christophe?
> 

Sure Michael, you can pick it up.

Thanks
Christophe