[PATCH] dt-bindings: kbuild: Fix dt_binding_check on unconfigured build

Rob Herring (Arm) posted 1 patch 1 year, 6 months ago
scripts/dtc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dt-bindings: kbuild: Fix dt_binding_check on unconfigured build
Posted by Rob Herring (Arm) 1 year, 6 months ago
The 'dt_binding_check' target shouldn't depend on the kernel
configuration, but it has since commit 604a57ba9781 ("dt-bindings:
kbuild: Add separate target/dependency for processed-schema.json").
That is because CHECK_DT_BINDING make variable was dropped, but
scripts/dtc/Makefile was missed. The CHECK_DTBS variable can be used
instead.

Reported-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Fixes: 604a57ba9781 ("dt-bindings: kbuild: Add separate target/dependency for processed-schema.json")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 scripts/dtc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index a18657072541..b47f4daa4515 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -3,7 +3,7 @@
 
 # *** Also keep .gitignore in sync when changing ***
 hostprogs-always-$(CONFIG_DTC)		+= dtc fdtoverlay
-hostprogs-always-$(CHECK_DT_BINDING)	+= dtc
+hostprogs-always-$(CHECK_DTBS)		+= dtc
 
 dtc-objs	:= dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
 		   srcpos.o checks.o util.o
-- 
2.43.0
Re: [PATCH] dt-bindings: kbuild: Fix dt_binding_check on unconfigured build
Posted by Masahiro Yamada 1 year, 6 months ago
On Wed, May 29, 2024 at 5:03 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> The 'dt_binding_check' target shouldn't depend on the kernel
> configuration, but it has since commit 604a57ba9781 ("dt-bindings:
> kbuild: Add separate target/dependency for processed-schema.json").
> That is because CHECK_DT_BINDING make variable was dropped, but
> scripts/dtc/Makefile was missed. The CHECK_DTBS variable can be used
> instead.
>
> Reported-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Fixes: 604a57ba9781 ("dt-bindings: kbuild: Add separate target/dependency for processed-schema.json")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>


Applied to linux-kbuild.
Thanks!


-- 
Best Regards
Masahiro Yamada