The function kdb_position_cursor() takes in a "prompt" parameter but
never uses it. This doesn't _really_ matter since all current callers
of the function pass the same value and it's a global variable, but
it's a bit ugly. Let's clean it up.

Found by code inspection. This patch is expected to functionally be a
no-op.

Fixes: 09b35989421d ("kdb: Use format-strings rather than '\0' injection in kdb_read()")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 kernel/debug/kdb/kdb_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 3131334d7a81..8e98446564a9 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -206,7 +206,7 @@ char kdb_getchar(void)
  */
 static void kdb_position_cursor(char *prompt, char *buffer, char *cp)
 {
-	kdb_printf("\r%s", kdb_prompt_str);
+	kdb_printf("\r%s", prompt);
 	if (cp > buffer)
 		kdb_printf("%.*s", (int)(cp - buffer), buffer);
 }
-- 
2.45.1.288.g0e0cd299f1-goog

On Tue, 28 May 2024 07:11:48 -0700, Douglas Anderson wrote:
> The function kdb_position_cursor() takes in a "prompt" parameter but
> never uses it. This doesn't _really_ matter since all current callers
> of the function pass the same value and it's a global variable, but
> it's a bit ugly. Let's clean it up.
> 
> Found by code inspection. This patch is expected to functionally be a
> no-op.
> 
> [...]

Applied, thanks!

[1/1] kdb: Use the passed prompt in kdb_position_cursor()
      commit: e2e821095949cde46256034975a90f88626a2a73

Best regards,
-- 
Daniel Thompson <daniel.thompson@linaro.org>