[PATCH net] net: smc91x: Remove commented out code

Thorsten Blum posted 1 patch 2 years, 1 month ago
There is a newer version of this series
drivers/net/ethernet/smsc/smc91x.c | 4 ----
1 file changed, 4 deletions(-)
[PATCH net] net: smc91x: Remove commented out code
Posted by Thorsten Blum 2 years, 1 month ago
Remove commented out code

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 drivers/net/ethernet/smsc/smc91x.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 78ff3af7911a..907498848028 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
 		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
 			return -EINVAL;
 
-//		lp->port = cmd->base.port;
 		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
 
-//		if (netif_running(dev))
-//			smc_set_port(dev);
-
 		ret = 0;
 	}
 
-- 
2.45.1
Re: [PATCH net] net: smc91x: Remove commented out code
Posted by Paolo Abeni 2 years, 1 month ago
Hi,

On Mon, 2024-05-27 at 12:55 +0200, Thorsten Blum wrote:
> Remove commented out code
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 78ff3af7911a..907498848028 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
>  		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
>  			return -EINVAL;
>  
> -//		lp->port = cmd->base.port;
>  		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
>  
> -//		if (netif_running(dev))
> -//			smc_set_port(dev);
> -
>  		ret = 0;
>  	}
>  
This is net-next material, please re-submit targeting the correct tree
in the subj prefix.

Thanks

Paolo
Re: [PATCH net] net: smc91x: Remove commented out code
Posted by Thorsten Blum 2 years, 1 month ago
On 28. May 2024, at 15:36, Paolo Abeni <pabeni@redhat.com> wrote:
> This is net-next material, please re-submit targeting the correct tree
> in the subj prefix.

Hi Paolo, I resubmitted the patch [1] with the correct prefix.

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/20240528160036.404946-2-thorsten.blum@toblux.com/