1. Patchew
  2. linux
  3. [PATCH v3 0/2] Add driver for Vishay VEML6040
  4. View patch

[PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

Arthur Becker via B4 Relay posted 2 patches 1 year, 8 months ago
There is a newer version of this series
[PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker via B4 Relay 1 year, 8 months ago 
From: Arthur Becker <arthur.becker@sentec.com>

Device tree bindings for the vishay VEML6040 RGBW light sensor iio
driver

Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
---
V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
along with v2 of the driver but not in a set)
---
 .../bindings/iio/light/vishay,veml6040.yaml        | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml
new file mode 100644
index 000000000000..101c2cc6506e
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/vishay,veml6040.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VEML6040 RGBW Light Sensor
+
+maintainers:
+  - Arthur Becker <arthur.becker@sentec.com>
+
+description:
+  Datasheet at https://www.vishay.com/docs/84276/veml6040.pdf
+
+properties:
+  compatible:
+    const: vishay,veml6040
+
+  reg:
+    enum:
+      - 0x10
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@10 {
+            compatible = "vishay,veml6040";
+            reg = <0x10>;
+            vdd-supply = <&vdd_reg>;
+        };
+    };
+...

-- 
2.34.1
Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Krzysztof Kozlowski 1 year, 8 months ago 
On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <arthur.becker@sentec.com>
> 
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
> 
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> ---
> V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> along with v2 of the driver but not in a set)

It's basically the same as veml6075, so should be put there...

Eh,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker 1 year, 8 months ago 
Thanks for the Review!
Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
I'll modify that the next time I make adjustments to the driver.

Kind regards,
Arthur

________________________________________
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 27 May 2024 18:31
To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <arthur.becker@sentec.com>
>
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
>
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> ---
> V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> along with v2 of the driver but not in a set)

It's basically the same as veml6075, so should be put there...

Eh,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Jonathan Cameron 1 year, 8 months ago 
On Tue, 28 May 2024 07:23:03 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

Hi Arthur,

If I read the above correctly you are hoping this merges as it stands and
we come back later. If we are going to combine them long term, 
I'd rather we avoided the churn and had a combined DT binding from the start.

Jonathan

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)  
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker 1 year, 8 months ago 
From: Jonathan Cameron <jic23@kernel.org>
Sent: 02 June 2024 15:16
To: Arthur Becker
Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

> On Tue, 28 May 2024 07:23:03 +0000
> Arthur Becker <arthur.becker@sentec.com> wrote:
> 
> > Thanks for the Review!
> > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > I'll modify that the next time I make adjustments to the driver.
>
> Hi Arthur,
>
> If I read the above correctly you are hoping this merges as it stands and
> we come back later. If we are going to combine them long term,
> I'd rather we avoided the churn and had a combined DT binding from the start.

Hi Jonathan,

I could have phrased that better, what I meant was that I was waiting for the next
feedback on the driver to make the adjustments all at once.
I'll get to it shortly!

Kind Regards,
Arthur

>
> Jonathan
>
> >
> > Kind regards,
> > Arthur
> >
> > ________________________________________
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 27 May 2024 18:31
> > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> >
> > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > > From: Arthur Becker <arthur.becker@sentec.com>
> > >
> > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > > driver
> > >
> > > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > > ---
> > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > > along with v2 of the driver but not in a set)
> >
> > It's basically the same as veml6075, so should be put there...
> >
> > Eh,
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Best regards,
> > Krzysztof
> >
Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Jonathan Cameron 1 year, 8 months ago 
On Mon, 3 Jun 2024 08:23:55 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> From: Jonathan Cameron <jic23@kernel.org>
> Sent: 02 June 2024 15:16
> To: Arthur Becker
> Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> > On Tue, 28 May 2024 07:23:03 +0000
> > Arthur Becker <arthur.becker@sentec.com> wrote:
> >   
> > > Thanks for the Review!
> > > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > > I'll modify that the next time I make adjustments to the driver.  
> >
> > Hi Arthur,
> >
> > If I read the above correctly you are hoping this merges as it stands and
> > we come back later. If we are going to combine them long term,
> > I'd rather we avoided the churn and had a combined DT binding from the start.  
> 
> Hi Jonathan,
> 
> I could have phrased that better, what I meant was that I was waiting for the next
> feedback on the driver to make the adjustments all at once.
> I'll get to it shortly!

Great :)

Thanks,

Jonathan

> 
> Kind Regards,
> Arthur
> 
> >
> > Jonathan
> >  
> > >
> > > Kind regards,
> > > Arthur
> > >
> > > ________________________________________
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: 27 May 2024 18:31
> > > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> > > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> > > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> > >
> > > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:  
> > > > From: Arthur Becker <arthur.becker@sentec.com>
> > > >
> > > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > > > driver
> > > >
> > > > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > > > ---
> > > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > > > along with v2 of the driver but not in a set)  
> > >
> > > It's basically the same as veml6075, so should be put there...
> > >
> > > Eh,
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >
> > > Best regards,
> > > Krzysztof
> > >  
>
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Rob Herring 1 year, 8 months ago 
On Tue, May 28, 2024 at 07:23:03AM +0000, Arthur Becker wrote:
> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

Please don't top post, quote replies correctly, and fix your mail setup 
to not add 'EXTERNAL' to the subject.

Rob

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings


> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker 1 year, 8 months ago 
>On Tue, May 28, 2024 at 07:23:03AM +0000, Arthur Becker wrote:
>> Thanks for the Review!
>> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
>> I'll modify that the next time I make adjustments to the driver.
>
>Please don't top post, quote replies correctly, and fix your mail setup
>to not add 'EXTERNAL' to the subject.
>
>Rob

Hello Rob,

Sorry about that, I'll keep that in mind in the future. Having to work with oulook can be a bit frustrating.

Kind Regards,
Arthur
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Jonathan Cameron 1 year, 8 months ago 
On Tue, 28 May 2024 07:23:03 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

It's absolutely fine to have shared bindings even if the
drivers (because of different register interface etc) are completely
separate.  It's a good way to keep bindings aligned between
similar devices.

Jonathan

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)  
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
>
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker 1 year, 8 months ago 
> From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Sent: 28 May 2024 12:05
> To: Arthur Becker
> Cc: Krzysztof Kozlowski; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
>
> On Tue, 28 May 2024 07:23:03 +0000
> Arthur Becker <arthur.becker@sentec.com> wrote:
>
> > Thanks for the Review!
> > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > I'll modify that the next time I make adjustments to the driver.
>
> It's absolutely fine to have shared bindings even if the
> drivers (because of different register interface etc) are completely
> separate.  It's a good way to keep bindings aligned between
> similar devices.
>
> Jonathan

Thanks for the answer, I'll keep that in mind!

Kind regards,
Arthur
Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Conor Dooley 1 year, 8 months ago 
On Mon, May 27, 2024 at 05:12:09PM +0200, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <arthur.becker@sentec.com>
> 
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
> 
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
Posted by Arthur Becker 1 year, 8 months ago 
Thanks for the Review!

Cheers,
Arthur
________________________________________
From: Conor Dooley
Sent: Monday, May 27, 2024 18:30
To: Arthur Becker
Cc: Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

On Mon, May 27, 2024 at 05:12:09PM +0200, Arthur Becker via B4 Relay wrote:

> From: Arthur Becker <arthur.becker@sentec.com>
>
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
>
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.