[PATCH 2/3] staging: rtl8192e: remove unnecessary line breaks

Michael Straube posted 3 patches 1 year, 8 months ago
There is a newer version of this series
[PATCH 2/3] staging: rtl8192e: remove unnecessary line breaks
Posted by Michael Straube 1 year, 8 months ago
Remove some unnecessary line breaks after '=' and '==' to improve
readability.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 24 ++++++++--------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 2fda44c5a412..5392d2daf870 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -1392,8 +1392,7 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_device *dev)
 				continue;
 
 			rf_num++;
-			cur_cck_pwdb =
-					dm_rx_path_sel_table.cck_pwdb_sta[i];
+			cur_cck_pwdb = dm_rx_path_sel_table.cck_pwdb_sta[i];
 
 			if (rf_num == 1) {
 				cck_rx_ver2_max_index = i;
@@ -1412,27 +1411,20 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_device *dev)
 				}
 			} else {
 				if (cur_cck_pwdb > tmp_cck_max_pwdb) {
-					tmp_cck_sec_pwdb =
-							tmp_cck_max_pwdb;
-					cck_rx_ver2_sec_index =
-							cck_rx_ver2_max_index;
+					tmp_cck_sec_pwdb = tmp_cck_max_pwdb;
+					cck_rx_ver2_sec_index = cck_rx_ver2_max_index;
 					tmp_cck_max_pwdb = cur_cck_pwdb;
 					cck_rx_ver2_max_index = i;
-				} else if (cur_cck_pwdb ==
-						tmp_cck_max_pwdb) {
+				} else if (cur_cck_pwdb == tmp_cck_max_pwdb) {
 					tmp_cck_sec_pwdb = cur_cck_pwdb;
 					cck_rx_ver2_sec_index = i;
 				} else if (PWDB_IN_RANGE) {
 					tmp_cck_sec_pwdb = cur_cck_pwdb;
 					cck_rx_ver2_sec_index = i;
-				} else if (cur_cck_pwdb ==
-						tmp_cck_sec_pwdb) {
-					if (tmp_cck_sec_pwdb ==
-						tmp_cck_min_pwdb) {
-						tmp_cck_sec_pwdb =
-								cur_cck_pwdb;
-						cck_rx_ver2_sec_index =
-								i;
+				} else if (cur_cck_pwdb == tmp_cck_sec_pwdb) {
+					if (tmp_cck_sec_pwdb == tmp_cck_min_pwdb) {
+						tmp_cck_sec_pwdb = cur_cck_pwdb;
+						cck_rx_ver2_sec_index = i;
 					}
 				} else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) &&
 						(cur_cck_pwdb > tmp_cck_min_pwdb)) {
-- 
2.45.1
Re: [PATCH 2/3] staging: rtl8192e: remove unnecessary line breaks
Posted by Nam Cao 1 year, 8 months ago
On Sun, May 26, 2024 at 01:19:27PM +0200, Michael Straube wrote:
> Remove some unnecessary line breaks after '=' and '==' to improve
> readability.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 24 ++++++++--------------
>  1 file changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 2fda44c5a412..5392d2daf870 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -1392,8 +1392,7 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_device *dev)
>  				continue;
>  
>  			rf_num++;
> -			cur_cck_pwdb =
> -					dm_rx_path_sel_table.cck_pwdb_sta[i];
> +			cur_cck_pwdb = dm_rx_path_sel_table.cck_pwdb_sta[i];
>  
>  			if (rf_num == 1) {
>  				cck_rx_ver2_max_index = i;
> @@ -1412,27 +1411,20 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_device *dev)
>  				}
>  			} else {
>  				if (cur_cck_pwdb > tmp_cck_max_pwdb) {
> -					tmp_cck_sec_pwdb =
> -							tmp_cck_max_pwdb;
> -					cck_rx_ver2_sec_index =
> -							cck_rx_ver2_max_index;
> +					tmp_cck_sec_pwdb = tmp_cck_max_pwdb;
> +					cck_rx_ver2_sec_index = cck_rx_ver2_max_index;
>  					tmp_cck_max_pwdb = cur_cck_pwdb;
>  					cck_rx_ver2_max_index = i;
> -				} else if (cur_cck_pwdb ==
> -						tmp_cck_max_pwdb) {
> +				} else if (cur_cck_pwdb == tmp_cck_max_pwdb) {
>  					tmp_cck_sec_pwdb = cur_cck_pwdb;
>  					cck_rx_ver2_sec_index = i;
>  				} else if (PWDB_IN_RANGE) {
>  					tmp_cck_sec_pwdb = cur_cck_pwdb;
>  					cck_rx_ver2_sec_index = i;
> -				} else if (cur_cck_pwdb ==
> -						tmp_cck_sec_pwdb) {
> -					if (tmp_cck_sec_pwdb ==
> -						tmp_cck_min_pwdb) {
> -						tmp_cck_sec_pwdb =
> -								cur_cck_pwdb;
> -						cck_rx_ver2_sec_index =
> -								i;
> +				} else if (cur_cck_pwdb == tmp_cck_sec_pwdb) {
> +					if (tmp_cck_sec_pwdb == tmp_cck_min_pwdb) {
> +						tmp_cck_sec_pwdb = cur_cck_pwdb;
> +						cck_rx_ver2_sec_index = i;
>  					}
>  				} else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) &&
>  						(cur_cck_pwdb > tmp_cck_min_pwdb)) {

Reviewed-by: Nam Cao <namcao@linutronix.de>

Best regards,
Nam