[PATCH] can: mscan: remove unused struct 'mscan_state'

linux@treblig.org posted 1 patch 1 year, 8 months ago
drivers/net/can/mscan/mscan.c | 6 ------
1 file changed, 6 deletions(-)
[PATCH] can: mscan: remove unused struct 'mscan_state'
Posted by linux@treblig.org 1 year, 8 months ago
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'mscan_state' is unused since the original
commit afa17a500a36 ("net/can: add driver for mscan family &
mpc52xx_mscan").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/net/can/mscan/mscan.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index a6829cdc0e81..8c2a7bc64d3d 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -34,12 +34,6 @@ static const struct can_bittiming_const mscan_bittiming_const = {
 	.brp_inc = 1,
 };
 
-struct mscan_state {
-	u8 mode;
-	u8 canrier;
-	u8 cantier;
-};
-
 static enum can_state state_map[] = {
 	CAN_STATE_ERROR_ACTIVE,
 	CAN_STATE_ERROR_WARNING,
-- 
2.45.1
Re: [PATCH] can: mscan: remove unused struct 'mscan_state'
Posted by Wolfram Sang 1 year, 8 months ago
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Wow, that driver was a long time ago. Thanks for the flashback :)

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Re: [PATCH] can: mscan: remove unused struct 'mscan_state'
Posted by Simon Horman 1 year, 8 months ago
On Sun, May 26, 2024 at 12:25:09AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Simon Horman <horms@kernel.org>