[v1] crypto: atmel-sha204a - fix negated return value

[PATCH] crypto: atmel-sha204a - fix negated return value

Lothar Rubusch posted 1 patch 1 year, 8 months ago

Diff against v1
Download mbox

There is a newer version of this series

drivers/crypto/atmel-sha204a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] crypto: atmel-sha204a - fix negated return value

Posted by Lothar Rubusch 1 year, 8 months ago

Fix negated variable return value.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-crypto/34cd4179-090e-479d-b459-8d0d35dd327d@moroto.mountain/
Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
 drivers/crypto/atmel-sha204a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 24ffdf505023..2034f6031518 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -106,7 +106,7 @@ static int atmel_sha204a_otp_read(struct i2c_client *client, u16 addr, u8 *otp)
 
 	if (cmd.data[0] == 0xff) {
 		dev_err(&client->dev, "failed, device not ready\n");
-		return -ret;
+		return -EINVAL;
 	}
 
 	memcpy(otp, cmd.data+1, 4);
-- 
2.39.2

Re: [PATCH] crypto: atmel-sha204a - fix negated return value

Posted by Markus Elfring 1 year, 8 months ago

> Fix negated variable return value.

Will it be helpful to add the tag “Fixes”?

Regards,
Markus