The struct cpuset is kzalloc'd, all the members are zeroed already,
so don't need nodes_clear() here.

No functional changes intended.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 kernel/cgroup/cpuset.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index c12b9fdb22a4..a553e3d46498 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -4009,8 +4009,6 @@ cpuset_css_alloc(struct cgroup_subsys_state *parent_css)
 	}
 
 	__set_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
-	nodes_clear(cs->mems_allowed);
-	nodes_clear(cs->effective_mems);
 	fmeter_init(&cs->fmeter);
 	cs->relax_domain_level = -1;
 	INIT_LIST_HEAD(&cs->remote_sibling);
-- 
2.34.1

On Sat, May 25, 2024 at 09:44:03AM +0000, Xiu Jianfeng wrote:
> The struct cpuset is kzalloc'd, all the members are zeroed already,
> so don't need nodes_clear() here.
> 
> No functional changes intended.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Applied to cgroup/for-6.11.

Thanks.

-- 
tejun

> The struct cpuset is kzalloc'd, all the members are zeroed already,
> so don't need nodes_clear() here.

* How do you think about to convert a part of this change description
  to an imperative wording?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94

* Please avoid a typo in the domain of an email address.

* Can the proposed source code cleanup be relevant for the addition
  of the tag “Fixes”?


Regards,
Markus