[PATCH net] dt-bindings: net: pse-pd: microchip,pd692x0: Fix missing "additionalProperties" constraints

Rob Herring (Arm) posted 1 patch 1 year, 8 months ago
.../bindings/net/pse-pd/microchip,pd692x0.yaml        | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
[PATCH net] dt-bindings: net: pse-pd: microchip,pd692x0: Fix missing "additionalProperties" constraints
Posted by Rob Herring (Arm) 1 year, 8 months ago
The child nodes are missing "additionalProperties" constraints which
means any undocumented properties or child nodes are allowed. Add the
constraints, and fix the fallout of wrong manager node regex and
missing properties.

Fixes: 9c1de033afad ("dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/net/pse-pd/microchip,pd692x0.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
index 828439398fdf..fd4244fceced 100644
--- a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
+++ b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
@@ -24,6 +24,7 @@ properties:
 
   managers:
     type: object
+    additionalProperties: false
     description:
       List of the PD69208T4/PD69204T4/PD69208M PSE managers. Each manager
       have 4 or 8 physical ports according to the chip version. No need to
@@ -47,8 +48,9 @@ properties:
       - "#size-cells"
 
     patternProperties:
-      "^manager@0[0-9a-b]$":
+      "^manager@[0-9a-b]$":
         type: object
+        additionalProperties: false
         description:
           PD69208T4/PD69204T4/PD69208M PSE manager exposing 4 or 8 physical
           ports.
@@ -69,9 +71,14 @@ properties:
         patternProperties:
           '^port@[0-7]$':
             type: object
+            additionalProperties: false
+
+            properties:
+              reg:
+                maxItems: 1
+
             required:
               - reg
-            additionalProperties: false
 
         required:
           - reg
-- 
2.43.0
Re: [PATCH net] dt-bindings: net: pse-pd: microchip,pd692x0: Fix missing "additionalProperties" constraints
Posted by Kory Maincent 1 year, 8 months ago
On Thu, 23 May 2024 12:17:31 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> The child nodes are missing "additionalProperties" constraints which
> means any undocumented properties or child nodes are allowed. Add the
> constraints, and fix the fallout of wrong manager node regex and
> missing properties.

Acked-by: Kory Maincent <kory.maincent@bootlin.com>

Thanks for these fixes!
Didn't know that "additionnalProperties" should be set on all child node, but
that makes sense.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com