[v3] Enhance AMD SMN Error Checking

[PATCH v3 7/8] hwmon: (k10temp) Remove unused HAVE_TDIE() macro

Posted by Yazen Ghannam 1 year, 8 months ago

...to address the following warning:

drivers/hwmon/k10temp.c:104:9:
warning: macro is not used [-Wunused-macros]

No functional change is intended.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 drivers/hwmon/k10temp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 6deb272c7cef..a2d203304533 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -101,7 +101,6 @@ struct k10temp_data {
 #define TCCD_BIT(x)	((x) + 2)
 
 #define HAVE_TEMP(d, channel)	((d)->show_temp & BIT(channel))
-#define HAVE_TDIE(d)		HAVE_TEMP(d, TDIE_BIT)
 
 struct tctl_offset {
 	u8 model;

-- 
2.34.1

Re: [PATCH v3 7/8] hwmon: (k10temp) Remove unused HAVE_TDIE() macro

Posted by Markus Elfring 1 year, 8 months ago

> ...to address the following warning:
>
> drivers/hwmon/k10temp.c:104:9:
> warning: macro is not used [-Wunused-macros]

Can such a source code cleanup matter also for the tag “Fixes”?

Regards,
Markus

Re: [PATCH v3 7/8] hwmon: (k10temp) Remove unused HAVE_TDIE() macro

Posted by Guenter Roeck 1 year, 8 months ago

On 5/23/24 11:26, Yazen Ghannam wrote:
> ...to address the following warning:
> 
> drivers/hwmon/k10temp.c:104:9:
> warning: macro is not used [-Wunused-macros]
> 
> No functional change is intended.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/k10temp.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 6deb272c7cef..a2d203304533 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -101,7 +101,6 @@ struct k10temp_data {
>   #define TCCD_BIT(x)	((x) + 2)
>   
>   #define HAVE_TEMP(d, channel)	((d)->show_temp & BIT(channel))
> -#define HAVE_TDIE(d)		HAVE_TEMP(d, TDIE_BIT)
>   
>   struct tctl_offset {
>   	u8 model;
>