arm64/crypto: Raise priority of NEON crct10dif implementation

[PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Mark Brown 1 year, 8 months ago

The NEON implementation of crctd10dif is registered with a priority of 100
which is identical to that used by the generic C implementation. Raise the
priority to 150, half way between the PMULL based implementation and the
NEON one, so that it will be preferred over the generic implementation.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/crypto/crct10dif-ce-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/crct10dif-ce-glue.c b/arch/arm64/crypto/crct10dif-ce-glue.c
index 09eb1456aed4..59016518f44d 100644
--- a/arch/arm64/crypto/crct10dif-ce-glue.c
+++ b/arch/arm64/crypto/crct10dif-ce-glue.c
@@ -98,7 +98,7 @@ static struct shash_alg crc_t10dif_alg[] = {{
 
 	.base.cra_name		= "crct10dif",
 	.base.cra_driver_name	= "crct10dif-arm64-neon",
-	.base.cra_priority	= 100,
+	.base.cra_priority	= 150,
 	.base.cra_blocksize	= CRC_T10DIF_BLOCK_SIZE,
 	.base.cra_module	= THIS_MODULE,
 }, {

---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240521-arm64-crct10dif-neon-prio-894a9350ec1e

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Herbert Xu 1 year, 8 months ago

On Tue, May 21, 2024 at 09:22:49PM +0100, Mark Brown wrote:
> The NEON implementation of crctd10dif is registered with a priority of 100
> which is identical to that used by the generic C implementation. Raise the
> priority to 150, half way between the PMULL based implementation and the
> NEON one, so that it will be preferred over the generic implementation.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/crypto/crct10dif-ce-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/crypto/crct10dif-ce-glue.c b/arch/arm64/crypto/crct10dif-ce-glue.c
> index 09eb1456aed4..59016518f44d 100644
> --- a/arch/arm64/crypto/crct10dif-ce-glue.c
> +++ b/arch/arm64/crypto/crct10dif-ce-glue.c
> @@ -98,7 +98,7 @@ static struct shash_alg crc_t10dif_alg[] = {{
>  
>  	.base.cra_name		= "crct10dif",
>  	.base.cra_driver_name	= "crct10dif-arm64-neon",
> -	.base.cra_priority	= 100,
> +	.base.cra_priority	= 150,
>  	.base.cra_blocksize	= CRC_T10DIF_BLOCK_SIZE,
>  	.base.cra_module	= THIS_MODULE,
>  }, {
> 
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240521-arm64-crct10dif-neon-prio-894a9350ec1e
> 
> Best regards,
> -- 
> Mark Brown <broonie@kernel.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Mark Brown 1 year, 8 months ago

On Tue, May 21, 2024 at 09:22:49PM +0100, Mark Brown wrote:
> The NEON implementation of crctd10dif is registered with a priority of 100
> which is identical to that used by the generic C implementation. Raise the
> priority to 150, half way between the PMULL based implementation and the
> NEON one, so that it will be preferred over the generic implementation.

That second NEON should be PMULL, sorry.

Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Will Deacon 1 year, 8 months ago

On Wed, May 22, 2024 at 12:17:41PM +0100, Mark Brown wrote:
> On Tue, May 21, 2024 at 09:22:49PM +0100, Mark Brown wrote:
> > The NEON implementation of crctd10dif is registered with a priority of 100
> > which is identical to that used by the generic C implementation. Raise the
> > priority to 150, half way between the PMULL based implementation and the
> > NEON one, so that it will be preferred over the generic implementation.
> 
> That second NEON should be PMULL, sorry.

Sorry, I don't grok that now:

  | half way between the PMULL based implementation and the PMULL one

doesn't mean anything?

Will

Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Mark Brown 1 year, 8 months ago

On Mon, Jun 03, 2024 at 02:15:08PM +0100, Will Deacon wrote:
> On Wed, May 22, 2024 at 12:17:41PM +0100, Mark Brown wrote:
> > On Tue, May 21, 2024 at 09:22:49PM +0100, Mark Brown wrote:
> > > The NEON implementation of crctd10dif is registered with a priority of 100
> > > which is identical to that used by the generic C implementation. Raise the
> > > priority to 150, half way between the PMULL based implementation and the
> > > NEON one, so that it will be preferred over the generic implementation.

> > That second NEON should be PMULL, sorry.

> Sorry, I don't grok that now:

>   | half way between the PMULL based implementation and the PMULL one

> doesn't mean anything?

Yes, one of those PMULLs should say generic (I thought I'd sent a
followup saying that, sorry).

Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

Posted by Ard Biesheuvel 1 year, 8 months ago

On Tue, 21 May 2024 at 22:23, Mark Brown <broonie@kernel.org> wrote:
>
> The NEON implementation of crctd10dif is registered with a priority of 100
> which is identical to that used by the generic C implementation. Raise the
> priority to 150, half way between the PMULL based implementation and the
> NEON one, so that it will be preferred over the generic implementation.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm64/crypto/crct10dif-ce-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/crct10dif-ce-glue.c b/arch/arm64/crypto/crct10dif-ce-glue.c
> index 09eb1456aed4..59016518f44d 100644
> --- a/arch/arm64/crypto/crct10dif-ce-glue.c
> +++ b/arch/arm64/crypto/crct10dif-ce-glue.c
> @@ -98,7 +98,7 @@ static struct shash_alg crc_t10dif_alg[] = {{
>
>         .base.cra_name          = "crct10dif",
>         .base.cra_driver_name   = "crct10dif-arm64-neon",
> -       .base.cra_priority      = 100,
> +       .base.cra_priority      = 150,
>         .base.cra_blocksize     = CRC_T10DIF_BLOCK_SIZE,
>         .base.cra_module        = THIS_MODULE,
>  }, {
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240521-arm64-crct10dif-neon-prio-894a9350ec1e
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
>