1. Patchew
  2. linux
  3. View series

[PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

linux@treblig.org posted 1 patch 1 year, 8 months ago 
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by linux@treblig.org 1 year, 8 months ago 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
has dropped all the users of the struct bridge_init from the
exynos_dp_core, while retaining unused structure definition.
Later on the driver was reworked and the definition migrated
to the analogix_dp driver. Remove unused struct bridge_init definition.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index df9370e0ff23..1e03f3525a92 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -36,11 +36,6 @@
 
 static const bool verify_fast_training;
 
-struct bridge_init {
-	struct i2c_client *client;
-	struct device_node *node;
-};
-
 static int analogix_dp_init_dp(struct analogix_dp_device *dp)
 {
 	int ret;
-- 
2.45.1
Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by Dmitry Baryshkov 1 year, 8 months ago 
On Mon, May 20, 2024 at 01:55:51PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> has dropped all the users of the struct bridge_init from the
> exynos_dp_core, while retaining unused structure definition.
> Later on the driver was reworked and the definition migrated
> to the analogix_dp driver. Remove unused struct bridge_init definition.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry
Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by Dr. David Alan Gilbert 1 year, 6 months ago 
* Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> On Mon, May 20, 2024 at 01:55:51PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > has dropped all the users of the struct bridge_init from the
> > exynos_dp_core, while retaining unused structure definition.
> > Later on the driver was reworked and the definition migrated
> > to the analogix_dp driver. Remove unused struct bridge_init definition.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Hi Dmitry,
  Do you know who is likely to pick this one up?  I think all
my other drm patches have found their way into -next.

Thanks,

Dave

> 
> -- 
> With best wishes
> Dmitry
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by Dmitry Baryshkov 1 year, 6 months ago 
On Thu, Jul 18, 2024 at 05:49:22PM GMT, Dr. David Alan Gilbert wrote:
> * Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> > On Mon, May 20, 2024 at 01:55:51PM +0100, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > > has dropped all the users of the struct bridge_init from the
> > > exynos_dp_core, while retaining unused structure definition.
> > > Later on the driver was reworked and the definition migrated
> > > to the analogix_dp driver. Remove unused struct bridge_init definition.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > ---
> > >  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Hi Dmitry,
>   Do you know who is likely to pick this one up?  I think all
> my other drm patches have found their way into -next.

Applied and pushed.

-- 
With best wishes
Dmitry
Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by Dr. David Alan Gilbert 1 year, 6 months ago 
* Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> On Thu, Jul 18, 2024 at 05:49:22PM GMT, Dr. David Alan Gilbert wrote:
> > * Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> > > On Mon, May 20, 2024 at 01:55:51PM +0100, linux@treblig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > 
> > > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > > > has dropped all the users of the struct bridge_init from the
> > > > exynos_dp_core, while retaining unused structure definition.
> > > > Later on the driver was reworked and the definition migrated
> > > > to the analogix_dp driver. Remove unused struct bridge_init definition.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > > ---
> > > >  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> > > >  1 file changed, 5 deletions(-)
> > > > 
> > > 
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > 
> > Hi Dmitry,
> >   Do you know who is likely to pick this one up?  I think all
> > my other drm patches have found their way into -next.
> 
> Applied and pushed.

Thanks!

Dave

> -- 
> With best wishes
> Dmitry
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'
Posted by Dr. David Alan Gilbert 1 year, 8 months ago 
* Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> On Mon, May 20, 2024 at 01:55:51PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > has dropped all the users of the struct bridge_init from the
> > exynos_dp_core, while retaining unused structure definition.
> > Later on the driver was reworked and the definition migrated
> > to the analogix_dp driver. Remove unused struct bridge_init definition.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Thanks.

Dave

> 
> -- 
> With best wishes
> Dmitry
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.