Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
compared with "fsl,imx28-dma-apbh".

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
it.

Keep the same restriction about 'power-domains' for other compatible
strings.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
index add9c77e8b52a..a17cf2360dd4a 100644
--- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
@@ -11,6 +11,17 @@ maintainers:
 
 allOf:
   - $ref: dma-controller.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8qxp-dma-apbh
+    then:
+      required:
+        - power-domains
+    else:
+      properties:
+        power-domains: false
 
 properties:
   compatible:
@@ -20,6 +31,7 @@ properties:
               - fsl,imx6q-dma-apbh
               - fsl,imx6sx-dma-apbh
               - fsl,imx7d-dma-apbh
+              - fsl,imx8qxp-dma-apbh
           - const: fsl,imx28-dma-apbh
       - enum:
           - fsl,imx23-dma-apbh
@@ -42,6 +54,9 @@ properties:
   dma-channels:
     enum: [4, 8, 16]
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg

-- 
2.34.1

On Mon, 2024-05-20 at 16:09:13 UTC, Frank Li wrote:
> Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> compared with "fsl,imx28-dma-apbh".
> 
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
> 
> Keep the same restriction about 'power-domains' for other compatible
> strings.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

Hi Vinod,

miquel.raynal@bootlin.com wrote on Mon, 27 May 2024 14:18:36 +0200:

> On Mon, 2024-05-20 at 16:09:13 UTC, Frank Li wrote:
> > Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> > compared with "fsl,imx28-dma-apbh".
> > 
> > Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> > it.
> > 
> > Keep the same restriction about 'power-domains' for other compatible
> > strings.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>  
> 
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

I just realize now I picked this up whereas it was not intended to be
merged through mtd. I'm fine keeping this patch for the next merge
window if I get your explicit agreement otherwise I'll drop it.

Thanks,
Miquèl

Hi,

miquel.raynal@bootlin.com wrote on Fri, 12 Jul 2024 16:35:03 +0200:

> Hi Vinod,
> 
> miquel.raynal@bootlin.com wrote on Mon, 27 May 2024 14:18:36 +0200:
> 
> > On Mon, 2024-05-20 at 16:09:13 UTC, Frank Li wrote:  
> > > Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> > > compared with "fsl,imx28-dma-apbh".
> > > 
> > > Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> > > it.
> > > 
> > > Keep the same restriction about 'power-domains' for other compatible
> > > strings.
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>    
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.  
> 
> I just realize now I picked this up whereas it was not intended to be
> merged through mtd. I'm fine keeping this patch for the next merge
> window if I get your explicit agreement otherwise I'll drop it.

I need to send the PR to Linux, I will drop this patch which can anyway
be taken in the next cycle.

Thanks,
Miquèl

On Fri, Jul 12, 2024 at 04:35:03PM +0200, Miquel Raynal wrote:
> Hi Vinod,
> 
> miquel.raynal@bootlin.com wrote on Mon, 27 May 2024 14:18:36 +0200:
> 
> > On Mon, 2024-05-20 at 16:09:13 UTC, Frank Li wrote:
> > > Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> > > compared with "fsl,imx28-dma-apbh".
> > > 
> > > Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> > > it.
> > > 
> > > Keep the same restriction about 'power-domains' for other compatible
> > > strings.
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>  
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
> 
> I just realize now I picked this up whereas it was not intended to be
> merged through mtd. I'm fine keeping this patch for the next merge
> window if I get your explicit agreement otherwise I'll drop it.

I think it is fine. Basically this dma is only used for GPMI NAND now.

Frank

> 
> Thanks,
> Miquèl

On Mon, 20 May 2024 12:09:13 -0400, Frank Li wrote:
> Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> compared with "fsl,imx28-dma-apbh".
> 
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
> 
> Keep the same restriction about 'power-domains' for other compatible
> strings.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>