[PATCH] ALSA: usb-audio: Fix for sampling rates support for Mbox3

Manuel Barrio Linares posted 1 patch 1 year, 9 months ago
sound/usb/quirks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] ALSA: usb-audio: Fix for sampling rates support for Mbox3
Posted by Manuel Barrio Linares 1 year, 9 months ago
Fixed wrong use of usb_sndctrlpipe to usb_rcvctrlpipe

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>
---
 sound/usb/quirks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 2f961f0e9378..58156fbca02c 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1740,7 +1740,7 @@ static void mbox3_set_format_quirk(struct snd_usb_substream *subs,
 	u32 current_rate;
 
 	// Get current rate from card and check if changing it is needed
-	snd_usb_ctl_msg(subs->dev, usb_sndctrlpipe(subs->dev, 0),
+	snd_usb_ctl_msg(subs->dev, usb_rcvctrlpipe(subs->dev, 0),
 					0x01, 0x21 | USB_DIR_IN, 0x0100, 0x8101, &buff4, 4);
 	current_rate = le32_to_cpu(buff4);
 	dev_dbg(&subs->dev->dev,
@@ -1765,7 +1765,7 @@ static void mbox3_set_format_quirk(struct snd_usb_substream *subs,
 
 	// Check whether the change was successful
 	buff4 = 0;
-	snd_usb_ctl_msg(subs->dev, usb_sndctrlpipe(subs->dev, 0),
+	snd_usb_ctl_msg(subs->dev, usb_rcvctrlpipe(subs->dev, 0),
 					0x01, 0x21 | USB_DIR_IN, 0x0100, 0x8101, &buff4, 4);
 	if (new_rate != le32_to_cpu(buff4))
 		dev_warn(&subs->dev->dev, "MBOX3: Couldn't set the sample rate");
-- 
2.45.1
Re: [PATCH] ALSA: usb-audio: Fix for sampling rates support for Mbox3
Posted by Takashi Iwai 1 year, 9 months ago
On Thu, 16 May 2024 15:40:02 +0200,
Manuel Barrio Linares wrote:
> 
> Fixed wrong use of usb_sndctrlpipe to usb_rcvctrlpipe
> 
> Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

Thanks, applied now with Fixes tag.


Takashi