[v1] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

[PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

Posted by linux@treblig.org 1 year, 9 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'moxart_filter_data' never appears to have been used.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/dma/moxart-dma.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index c48d68cbff92..66dc6d31b603 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -148,11 +148,6 @@ struct moxart_dmadev {
 	unsigned int			irq;
 };
 
-struct moxart_filter_data {
-	struct moxart_dmadev		*mdc;
-	struct of_phandle_args		*dma_spec;
-};
-
 static const unsigned int es_bytes[] = {
 	[MOXART_DMA_DATA_TYPE_S8] = 1,
 	[MOXART_DMA_DATA_TYPE_S16] = 2,
-- 
2.45.0

Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

Posted by Frank Li 1 year, 9 months ago

On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'moxart_filter_data' never appears to have been used.
> Remove it.

You can duplicate subject.

Remove unused struct moxart_filter_data.

> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/dma/moxart-dma.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> index c48d68cbff92..66dc6d31b603 100644
> --- a/drivers/dma/moxart-dma.c
> +++ b/drivers/dma/moxart-dma.c
> @@ -148,11 +148,6 @@ struct moxart_dmadev {
>  	unsigned int			irq;
>  };
>  
> -struct moxart_filter_data {
> -	struct moxart_dmadev		*mdc;
> -	struct of_phandle_args		*dma_spec;
> -};
> -
>  static const unsigned int es_bytes[] = {
>  	[MOXART_DMA_DATA_TYPE_S8] = 1,
>  	[MOXART_DMA_DATA_TYPE_S16] = 2,
> -- 
> 2.45.0
>

Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

Posted by Dr. David Alan Gilbert 1 year, 9 months ago

* Frank Li (Frank.li@nxp.com) wrote:
> On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'moxart_filter_data' never appears to have been used.
> > Remove it.
> 
> You can duplicate subject.
> 
> Remove unused struct moxart_filter_data.

V2 sent.

Dave

> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/dma/moxart-dma.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> > index c48d68cbff92..66dc6d31b603 100644
> > --- a/drivers/dma/moxart-dma.c
> > +++ b/drivers/dma/moxart-dma.c
> > @@ -148,11 +148,6 @@ struct moxart_dmadev {
> >  	unsigned int			irq;
> >  };
> >  
> > -struct moxart_filter_data {
> > -	struct moxart_dmadev		*mdc;
> > -	struct of_phandle_args		*dma_spec;
> > -};
> > -
> >  static const unsigned int es_bytes[] = {
> >  	[MOXART_DMA_DATA_TYPE_S8] = 1,
> >  	[MOXART_DMA_DATA_TYPE_S16] = 2,
> > -- 
> > 2.45.0
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/