[PATCH 19/31] Staging: rtl8192e: Rename variable ChkLength

Tree Davies posted 31 patches 1 year, 9 months ago
There is a newer version of this series
[PATCH 19/31] Staging: rtl8192e: Rename variable ChkLength
Posted by Tree Davies 1 year, 9 months ago
Rename variable ChkLength to chk_length
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 3223619f8cd9..ca1c748ac40c 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -729,7 +729,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 	u16		fc = le16_to_cpu(hdr->frame_control);
 
 	u16		llc_offset = sizeof(struct ieee80211_hdr_3addr);
-	u16		ChkLength;
+	u16		chk_length;
 	bool		is_aggregate_frame = false;
 	u16		nSubframe_Length;
 	u8		npadding_length = 0;
@@ -746,9 +746,9 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 	if (rx_stats->contain_htc)
 		llc_offset += sHTCLng;
 
-	ChkLength = llc_offset;
+	chk_length = llc_offset;
 
-	if (skb->len <= ChkLength)
+	if (skb->len <= chk_length)
 		return 0;
 
 	skb_pull(skb, llc_offset);
-- 
2.30.2
Re: [PATCH 19/31] Staging: rtl8192e: Rename variable ChkLength
Posted by Dan Carpenter 1 year, 9 months ago
On Tue, May 14, 2024 at 09:52:16PM -0700, Tree Davies wrote:
> Rename variable ChkLength to chk_length
> to fix checkpatch warning Avoid CamelCase.
> 

Just use llc_directly and delete ChkLength variable.

regards,
dan carpenter
Re: [PATCH 19/31] Staging: rtl8192e: Rename variable ChkLength
Posted by <Tree Davies 1 year, 8 months ago
On Wed, May 15, 2024 at 12:31:20PM +0200, Dan Carpenter wrote:
> On Tue, May 14, 2024 at 09:52:16PM -0700, Tree Davies wrote:
> > Rename variable ChkLength to chk_length
> > to fix checkpatch warning Avoid CamelCase.
> > 
> 
> Just use llc_directly and delete ChkLength variable.
> 
> regards,
> dan carpenter
> 

Thanks Dan, I will send a v2.
~Tree