[v2] Add support for AD411x

[PATCH v2 7/9] iio: adc: ad7173: Remove index from temp channel

Posted by Dumitru Ceclan via B4 Relay 1 year, 9 months ago

From: Dumitru Ceclan <dumitru.ceclan@analog.com>

Temperature channel is unique per device, index is not needed.

This is breaking userspace: as main driver has not reached mainline yet
it won't affect users as there are none.

Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
 drivers/iio/adc/ad7173.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index d965b66d4d5a..d66b47e1a186 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -828,7 +828,6 @@ static const struct iio_chan_spec ad7173_channel_template = {
 
 static const struct iio_chan_spec ad7173_temp_iio_channel_template = {
 	.type = IIO_TEMP,
-	.indexed = 1,
 	.channel = AD7173_AIN_TEMP_POS,
 	.channel2 = AD7173_AIN_TEMP_NEG,
 	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |

-- 
2.43.0

Re: [PATCH v2 7/9] iio: adc: ad7173: Remove index from temp channel

Posted by David Lechner 1 year, 9 months ago

On Tue, May 14, 2024 at 2:23 AM Dumitru Ceclan via B4 Relay
<devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
>
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>
> Temperature channel is unique per device, index is not needed.
>
> This is breaking userspace: as main driver has not reached mainline yet
> it won't affect users as there are none.

But it is queued up, so probably need a Fixes: here to make sure it
makes it into the release.

>
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---
>  drivers/iio/adc/ad7173.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index d965b66d4d5a..d66b47e1a186 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -828,7 +828,6 @@ static const struct iio_chan_spec ad7173_channel_template = {
>
>  static const struct iio_chan_spec ad7173_temp_iio_channel_template = {
>         .type = IIO_TEMP,
> -       .indexed = 1,
>         .channel = AD7173_AIN_TEMP_POS,
>         .channel2 = AD7173_AIN_TEMP_NEG,
>         .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
>
> --
> 2.43.0
>
>

Re: [PATCH v2 7/9] iio: adc: ad7173: Remove index from temp channel

Posted by Jonathan Cameron 1 year, 8 months ago

On Wed, 15 May 2024 18:34:17 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On Tue, May 14, 2024 at 2:23 AM Dumitru Ceclan via B4 Relay
> <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
> >
> > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> >
> > Temperature channel is unique per device, index is not needed.
> >
> > This is breaking userspace: as main driver has not reached mainline yet
> > it won't affect users as there are none.  
> 
> But it is queued up, so probably need a Fixes: here to make sure it
> makes it into the release.
Yes. We can fix this but it will need to go as a fix during the rc cycles
rather than wait for the next merge window like the rest of this series.

Jonathan



> 
> >
> > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > ---
> >  drivers/iio/adc/ad7173.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index d965b66d4d5a..d66b47e1a186 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -828,7 +828,6 @@ static const struct iio_chan_spec ad7173_channel_template = {
> >
> >  static const struct iio_chan_spec ad7173_temp_iio_channel_template = {
> >         .type = IIO_TEMP,
> > -       .indexed = 1,
> >         .channel = AD7173_AIN_TEMP_POS,
> >         .channel2 = AD7173_AIN_TEMP_NEG,
> >         .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> >
> > --
> > 2.43.0
> >
> >