crypto: ccree: Remove unused struct 'tdes_keys'

[PATCH] crypto: ccree: Remove unused struct 'tdes_keys'

Posted by linux@treblig.org 1 year, 7 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'tdes_keys' appears unused.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/crypto/ccree/cc_cipher.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
index cd66a580e8b64..3fb667a17bbb1 100644
--- a/drivers/crypto/ccree/cc_cipher.c
+++ b/drivers/crypto/ccree/cc_cipher.c
@@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
 	kfree_sensitive(ctx_p->user.key);
 }
 
-struct tdes_keys {
-	u8	key1[DES_KEY_SIZE];
-	u8	key2[DES_KEY_SIZE];
-	u8	key3[DES_KEY_SIZE];
-};
-
 static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
 {
 	switch (slot_num) {
-- 
2.45.0

Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'

Posted by Herbert Xu 1 year, 6 months ago

On Sat, May 11, 2024 at 03:52:00PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'tdes_keys' appears unused.
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 6 ------
>  1 file changed, 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'

Posted by Gilad Ben-Yossef 1 year, 6 months ago

Hi David,

On Sat, May 11, 2024 at 5:52 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thank you for the patch and your patience.

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
>         kfree_sensitive(ctx_p->user.key);
>  }
>
> -struct tdes_keys {
> -       u8      key1[DES_KEY_SIZE];
> -       u8      key2[DES_KEY_SIZE];
> -       u8      key3[DES_KEY_SIZE];
> -};
> -
>  static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
>  {
>         switch (slot_num) {
> --
> 2.45.0
>


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!

Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'tdes_keys' appears unused.
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.

> ---
>  drivers/crypto/ccree/cc_cipher.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
>  	kfree_sensitive(ctx_p->user.key);
>  }
>  
> -struct tdes_keys {
> -	u8	key1[DES_KEY_SIZE];
> -	u8	key2[DES_KEY_SIZE];
> -	u8	key3[DES_KEY_SIZE];
> -};
> -
>  static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
>  {
>  	switch (slot_num) {
> -- 
> 2.45.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/