crypto: acix: Remove unused struct 'dbgfs_u32'

[PATCH] crypto: acix: Remove unused struct 'dbgfs_u32'

Posted by linux@treblig.org 1 year, 7 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'dbgfs_u32' appears unused.
Remove it.
(pdma_stat_descr is also unused, but I'm assuming it's
some useful layout description of firmware/hardware
so best left in)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/crypto/axis/artpec6_crypto.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index dbc1d483f2afa..75440ea6206e2 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -2811,13 +2811,6 @@ static struct aead_alg aead_algos[] = {
 
 #ifdef CONFIG_DEBUG_FS
 
-struct dbgfs_u32 {
-	char *name;
-	mode_t mode;
-	u32 *flag;
-	char *desc;
-};
-
 static struct dentry *dbgfs_root;
 
 static void artpec6_crypto_init_debugfs(void)
-- 
2.45.0

Re: [PATCH] crypto: acix: Remove unused struct 'dbgfs_u32'

Posted by Herbert Xu 1 year, 6 months ago

On Sat, May 11, 2024 at 03:50:17PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'dbgfs_u32' appears unused.
> Remove it.
> (pdma_stat_descr is also unused, but I'm assuming it's
> some useful layout description of firmware/hardware
> so best left in)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/axis/artpec6_crypto.c | 7 -------
>  1 file changed, 7 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: acix: Remove unused struct 'dbgfs_u32'

Posted by Jesper Nilsson 1 year, 6 months ago

On Sat, May 11, 2024 at 03:50:17PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'dbgfs_u32' appears unused.
> Remove it.
> (pdma_stat_descr is also unused, but I'm assuming it's
> some useful layout description of firmware/hardware
> so best left in)

IIRC, the stat data is of this format, but it is only
checked for "non-zero" as indicator a finished job.

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

Re: [PATCH] crypto: acix: Remove unused struct 'dbgfs_u32'

Posted by Dr. David Alan Gilbert 1 year, 6 months ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'dbgfs_u32' appears unused.
> Remove it.
> (pdma_stat_descr is also unused, but I'm assuming it's
> some useful layout description of firmware/hardware
> so best left in)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.

Dave

> ---
>  drivers/crypto/axis/artpec6_crypto.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
> index dbc1d483f2afa..75440ea6206e2 100644
> --- a/drivers/crypto/axis/artpec6_crypto.c
> +++ b/drivers/crypto/axis/artpec6_crypto.c
> @@ -2811,13 +2811,6 @@ static struct aead_alg aead_algos[] = {
>  
>  #ifdef CONFIG_DEBUG_FS
>  
> -struct dbgfs_u32 {
> -	char *name;
> -	mode_t mode;
> -	u32 *flag;
> -	char *desc;
> -};
> -
>  static struct dentry *dbgfs_root;
>  
>  static void artpec6_crypto_init_debugfs(void)
> -- 
> 2.45.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/