Adreno cooling, take 2

[PATCH 00/12] Adreno cooling, take 2

Posted by Konrad Dybcio 1 year, 7 months ago

For the thermal framework to cool devfreq-managed devices properly,
it seems like the following conditions must be met:

1. the devfreq device has a cooling device associated with it
2. there exists some thermal zone provider
3. the cooling device is referenced in a cooling map
4. the cooling map is associated with a thermal trip point
5. the thermal trip point is of the "passive" kind
6. the "passive" trip point is being updated (via polling or otherwise)
7. the trip point is being hit (i.e. the thing gets hot enough)

Various QC DTs have various issues, mostly around 4, 5, 6 and 7.
This series tries to amend the platforms that currently can't have
Adreno throttled, without making much unnecessary/debatable mess,
although sneaking in some configuration unification/standardization.

Further updates can be made in the future.

This was originally brought into attention by Daniel in [1], this
series resolves the issues on a treewide scale.

Developed atop (and thereby depends on) [2].

[1] https://lore.kernel.org/linux-arm-msm/20240116115921.804185-1-daniel.lezcano@linaro.org/
[2] https://lore.kernel.org/linux-arm-msm/b4dba1d5-448a-4a4b-94d5-f27c6ff0010d@linaro.org/T/#t

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (12):
      arm64: dts: qcom: sc8180x: Throttle the GPU when overheating
      arm64: dts: qcom: sc8280xp: Throttle the GPU when overheating
      arm64: dts: qcom: sdm630: Throttle the GPU when overheating
      arm64: dts: qcom: sdm845: Throttle the GPU when overheating
      arm64: dts: qcom: sm6115: Update GPU thermal zone settings
      arm64: dts: qcom: sm6350: Update GPU thermal zone settings
      arm64: dts: qcom: sm8150: Throttle the GPU when overheating
      arm64: dts: qcom: sm8250: Throttle the GPU when overheating
      arm64: dts: qcom: sm8350: Throttle the GPU when overheating
      arm64: dts: qcom: sm8450: Throttle the GPU when overheating
      arm64: dts: qcom: sm8550: Throttle the GPU when overheating
      arm64: dts: qcom: sm8650: Throttle the GPU when overheating

 arch/arm64/boot/dts/qcom/sc8180x.dtsi  |  28 ++++-
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi |  17 ++-
 arch/arm64/boot/dts/qcom/sdm630.dtsi   |  12 ++
 arch/arm64/boot/dts/qcom/sdm845.dtsi   |  28 ++++-
 arch/arm64/boot/dts/qcom/sm6115.dtsi   |   8 +-
 arch/arm64/boot/dts/qcom/sm6350.dtsi   |  16 ++-
 arch/arm64/boot/dts/qcom/sm8150.dtsi   |  28 ++++-
 arch/arm64/boot/dts/qcom/sm8250.dtsi   |  28 ++++-
 arch/arm64/boot/dts/qcom/sm8350.dtsi   |  24 ++++
 arch/arm64/boot/dts/qcom/sm8450.dtsi   |  48 +++-----
 arch/arm64/boot/dts/qcom/sm8550.dtsi   | 208 +++++++++++++--------------------
 arch/arm64/boot/dts/qcom/sm8650.dtsi   | 169 ++++++++++++++++++++++-----
 12 files changed, 406 insertions(+), 208 deletions(-)
---
base-commit: 2adffd063e54f8790132eedfaf3019bfb6f62268
change-id: 20240510-topic-gpus_are_cool_now-ed8d8c4f5f7f

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

Re: [PATCH 00/12] Adreno cooling, take 2

Posted by Bjorn Andersson 1 year, 6 months ago

On Fri, 10 May 2024 14:58:29 +0200, Konrad Dybcio wrote:
> For the thermal framework to cool devfreq-managed devices properly,
> it seems like the following conditions must be met:
> 
> 1. the devfreq device has a cooling device associated with it
> 2. there exists some thermal zone provider
> 3. the cooling device is referenced in a cooling map
> 4. the cooling map is associated with a thermal trip point
> 5. the thermal trip point is of the "passive" kind
> 6. the "passive" trip point is being updated (via polling or otherwise)
> 7. the trip point is being hit (i.e. the thing gets hot enough)
> 
> [...]

Applied, thanks!

[01/12] arm64: dts: qcom: sc8180x: Throttle the GPU when overheating
        commit: 7c05517e5e68205c9d5085c029df2ca4e6ad9237
[02/12] arm64: dts: qcom: sc8280xp: Throttle the GPU when overheating
        commit: f7fd6d04c1046107a87a0fc883ed044cf8b877a1
[03/12] arm64: dts: qcom: sdm630: Throttle the GPU when overheating
        commit: 545fef1e5e43fb73083d16507a13820179726ebe
[04/12] arm64: dts: qcom: sdm845: Throttle the GPU when overheating
        commit: b79dd56ed5fcc863f167eb53771b09e8b3d8e317
[05/12] arm64: dts: qcom: sm6115: Update GPU thermal zone settings
        commit: c518b5f6def159222d73f3241fb1802bc846a477
[06/12] arm64: dts: qcom: sm6350: Update GPU thermal zone settings
        commit: 1a558bbffc2ee9b99226b146fd7928e41db79d41
[07/12] arm64: dts: qcom: sm8150: Throttle the GPU when overheating
        commit: c61300433b7b89d5782fddf95bd96a6e819c0377
[08/12] arm64: dts: qcom: sm8250: Throttle the GPU when overheating
        commit: c862b78b7203b72dd6806a77c0feff60fe96dee5
[09/12] arm64: dts: qcom: sm8350: Throttle the GPU when overheating
        commit: 10a5555220ad20b2f8043060d76b0e7f83ae91fa
[10/12] arm64: dts: qcom: sm8450: Throttle the GPU when overheating
        commit: 4be0dd44c39b083148ae9d4c4a7ef6d64e6c0062
[11/12] arm64: dts: qcom: sm8550: Throttle the GPU when overheating
        commit: ed979c039ad1c9b02dd7e9fa6a0dd69209bac6ed
[12/12] arm64: dts: qcom: sm8650: Throttle the GPU when overheating
        commit: 497624ed550604b3f713f53bc506e49ce5046e5f

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>