arm64: dts: qcom: sc8280xp: Set status = "reserved" on PSHOLD

[PATCH] arm64: dts: qcom: sc8280xp: Set status = "reserved" on PSHOLD

Posted by Konrad Dybcio 1 year, 7 months ago

On most devices, TZ seems to be blocking access to the PSHOLD reboot
register. This seems to be TZ, as even kicking the hypervisor doesn't
seem to make it writable.

Fixes: 865ff2e6f5da ("arm64: dts: qcom: sc8280xp: Add PS_HOLD restart")
Reported-by: Steev Klimaszewski <steev@kali.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 0549ba1fbeea..59f0a850671a 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -4623,6 +4623,8 @@ tsens0: thermal-sensor@c263000 {
 		restart@c264000 {
 			compatible = "qcom,pshold";
 			reg = <0 0x0c264000 0 0x4>;
+			/* TZ seems to block access */
+			status = "reserved";
 		};
 
 		tsens1: thermal-sensor@c265000 {

---
base-commit: 704ba27ac55579704ba1289392448b0c66b56258
change-id: 20240510-topic-8280_off-11539fc57f98

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

Re: [PATCH] arm64: dts: qcom: sc8280xp: Set status = "reserved" on PSHOLD

Posted by Bjorn Andersson 1 year, 6 months ago

On Fri, 10 May 2024 15:39:59 +0200, Konrad Dybcio wrote:
> On most devices, TZ seems to be blocking access to the PSHOLD reboot
> register. This seems to be TZ, as even kicking the hypervisor doesn't
> seem to make it writable.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp: Set status = "reserved" on PSHOLD
      commit: 8a1fd54d007279207c1dfe090084749706fb413b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: sc8280xp: Set status = "reserved" on PSHOLD

Posted by Steev Klimaszewski 1 year, 7 months ago

Hi Konrad,

On Fri, May 10, 2024 at 8:40 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On most devices, TZ seems to be blocking access to the PSHOLD reboot
> register. This seems to be TZ, as even kicking the hypervisor doesn't
> seem to make it writable.
>
> Fixes: 865ff2e6f5da ("arm64: dts: qcom: sc8280xp: Add PS_HOLD restart")
> Reported-by: Steev Klimaszewski <steev@kali.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 0549ba1fbeea..59f0a850671a 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -4623,6 +4623,8 @@ tsens0: thermal-sensor@c263000 {
>                 restart@c264000 {
>                         compatible = "qcom,pshold";
>                         reg = <0 0x0c264000 0 0x4>;
> +                       /* TZ seems to block access */
> +                       status = "reserved";
>                 };
>
>                 tsens1: thermal-sensor@c265000 {
>
> ---
> base-commit: 704ba27ac55579704ba1289392448b0c66b56258
> change-id: 20240510-topic-8280_off-11539fc57f98
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
Tested on my X13s here and confirmed it does what it says on the tin now :)
Tested-by: Steev Klimaszewski <steev@kali.org>