time: add MODULE_DESCRIPTION() to time test modules

[PATCH] time: add MODULE_DESCRIPTION() to time test modules

Posted by Jeff Johnson 1 year, 9 months ago

Fix the make W=1 warnings:

WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 kernel/time/clocksource-wdtest.c | 1 +
 kernel/time/test_udelay.c        | 1 +
 kernel/time/time_test.c          | 1 +
 3 files changed, 3 insertions(+)

diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
index d06185e054ea..62e73444ffe4 100644
--- a/kernel/time/clocksource-wdtest.c
+++ b/kernel/time/clocksource-wdtest.c
@@ -22,6 +22,7 @@
 #include "tick-internal.h"
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Clocksource watchdog unit test");
 MODULE_AUTHOR("Paul E. McKenney <paulmck@kernel.org>");
 
 static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
index 20d5df631570..783f2297111b 100644
--- a/kernel/time/test_udelay.c
+++ b/kernel/time/test_udelay.c
@@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
 
 module_exit(udelay_test_exit);
 
+MODULE_DESCRIPTION("udelay test module");
 MODULE_AUTHOR("David Riley <davidriley@chromium.org>");
 MODULE_LICENSE("GPL");
diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
index 3e5d422dd15c..2889763165e5 100644
--- a/kernel/time/time_test.c
+++ b/kernel/time/time_test.c
@@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
 };
 
 kunit_test_suite(time_test_suite);
+MODULE_DESCRIPTION("time unit test suite");
 MODULE_LICENSE("GPL");

---
base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
change-id: 20240510-time-md-0f1514019230

Re: [PATCH] time: add MODULE_DESCRIPTION() to time test modules

Posted by Paul E. McKenney 1 year, 9 months ago

On Fri, May 10, 2024 at 05:24:25PM -0700, Jeff Johnson wrote:
> Fix the make W=1 warnings:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

From a clocksource-watchdog-test perspective:

Acked-by: Paul E. McKenney <paulmck@kernel.org>

> ---
>  kernel/time/clocksource-wdtest.c | 1 +
>  kernel/time/test_udelay.c        | 1 +
>  kernel/time/time_test.c          | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
> index d06185e054ea..62e73444ffe4 100644
> --- a/kernel/time/clocksource-wdtest.c
> +++ b/kernel/time/clocksource-wdtest.c
> @@ -22,6 +22,7 @@
>  #include "tick-internal.h"
>  
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Clocksource watchdog unit test");
>  MODULE_AUTHOR("Paul E. McKenney <paulmck@kernel.org>");
>  
>  static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
> diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
> index 20d5df631570..783f2297111b 100644
> --- a/kernel/time/test_udelay.c
> +++ b/kernel/time/test_udelay.c
> @@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
>  
>  module_exit(udelay_test_exit);
>  
> +MODULE_DESCRIPTION("udelay test module");
>  MODULE_AUTHOR("David Riley <davidriley@chromium.org>");
>  MODULE_LICENSE("GPL");
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 3e5d422dd15c..2889763165e5 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
>  };
>  
>  kunit_test_suite(time_test_suite);
> +MODULE_DESCRIPTION("time unit test suite");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
> change-id: 20240510-time-md-0f1514019230
>

[tip: timers/core] time: Add MODULE_DESCRIPTION() to time test modules

Posted by tip-bot2 for Jeff Johnson 1 year, 8 months ago

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     7cbf3b13f00c8341afff1c48ad83d11995842c40
Gitweb:        https://git.kernel.org/tip/7cbf3b13f00c8341afff1c48ad83d11995842c40
Author:        Jeff Johnson <quic_jjohnson@quicinc.com>
AuthorDate:    Fri, 10 May 2024 17:24:25 -07:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 03 Jun 2024 11:18:50 +02:00

time: Add MODULE_DESCRIPTION() to time test modules

Fix the make W=1 warnings:

WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20240510-time-md-v1-1-44a8a36ac4b0@quicinc.com

---
 kernel/time/clocksource-wdtest.c | 1 +
 kernel/time/test_udelay.c        | 1 +
 kernel/time/time_test.c          | 1 +
 3 files changed, 3 insertions(+)

diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
index d06185e..62e7344 100644
--- a/kernel/time/clocksource-wdtest.c
+++ b/kernel/time/clocksource-wdtest.c
@@ -22,6 +22,7 @@
 #include "tick-internal.h"
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Clocksource watchdog unit test");
 MODULE_AUTHOR("Paul E. McKenney <paulmck@kernel.org>");
 
 static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
index 20d5df6..783f229 100644
--- a/kernel/time/test_udelay.c
+++ b/kernel/time/test_udelay.c
@@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
 
 module_exit(udelay_test_exit);
 
+MODULE_DESCRIPTION("udelay test module");
 MODULE_AUTHOR("David Riley <davidriley@chromium.org>");
 MODULE_LICENSE("GPL");
diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
index 3e5d422..2889763 100644
--- a/kernel/time/time_test.c
+++ b/kernel/time/time_test.c
@@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
 };
 
 kunit_test_suite(time_test_suite);
+MODULE_DESCRIPTION("time unit test suite");
 MODULE_LICENSE("GPL");