arch/arm/boot/dts/ti/davinci/da850-evm.dts | 2 +- arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 2 +- arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 2 +- arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
DT schema expects panel timings node to follow certain pattern,
dtbs_check warnings:
am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+'
Linux drivers do not care about node name, so this should not have
effect on Linux.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/ti/davinci/da850-evm.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/ti/davinci/da850-evm.dts b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
index 6c5936278e75..1f5cd35f8b74 100644
--- a/arch/arm/boot/dts/ti/davinci/da850-evm.dts
+++ b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
@@ -65,7 +65,7 @@ panel-info {
display-timings {
native-mode = <&timing0>;
- timing0: 480x272 {
+ timing0: timing-480x272 {
clock-frequency = <9000000>;
hactive = <480>;
vactive = <272>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
index 56e5d954a490..4b070e634b28 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
@@ -74,7 +74,7 @@ panel {
pinctrl-1 = <&lcd_pins_sleep>;
display-timings {
- 320x240 {
+ timing-320x240 {
hactive = <320>;
vactive = <240>;
hback-porch = <68>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
index f38f5bff2b96..17574d0d0525 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
@@ -67,7 +67,7 @@ panel-info {
};
display-timings {
- 240x320p16 {
+ timing-240x320p16 {
clock-frequency = <6500000>;
hactive = <240>;
vactive = <320>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
index d5a4a21889d1..e7d561a527fd 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
@@ -202,7 +202,7 @@ panel-info {
};
display-timings {
native-mode = <&timing0>;
- timing0: 480x272 {
+ timing0: timing-480x272 {
clock-frequency = <18400000>;
hactive = <480>;
vactive = <272>;
--
2.43.0
On Thu, 09 May 2024 12:48:13 +0200, Krzysztof Kozlowski wrote:
> DT schema expects panel timings node to follow certain pattern,
> dtbs_check warnings:
>
> am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+'
>
> Linux drivers do not care about node name, so this should not have
> effect on Linux.
>
> [...]
1.5 months on the lists, but maybe I combined too many separate TI maintainers,
so no one feels responsible... then I guess I will take it.
Applied, thanks!
[1/1] ARM: dts: ti: align panel timings node name with dtschema
https://git.kernel.org/krzk/linux-dt/c/93ba8817f2ea13593d1c43e02a819cb7d9be048b
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On Wed, Jun 26, 2024 at 1:26 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > On Thu, 09 May 2024 12:48:13 +0200, Krzysztof Kozlowski wrote: > > DT schema expects panel timings node to follow certain pattern, > > dtbs_check warnings: > > > > am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+' > > > > Linux drivers do not care about node name, so this should not have > > effect on Linux. > > > > [...] > > 1.5 months on the lists, but maybe I combined too many separate TI maintainers, > so no one feels responsible... then I guess I will take it. > Yeah next time you should probably at least split omap and davinci bits into separate patches. Otherwise I think Tony thought I'd pick it up and vice versa. Bart
On 26/06/2024 13:47, Bartosz Golaszewski wrote: > On Wed, Jun 26, 2024 at 1:26 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> >> On Thu, 09 May 2024 12:48:13 +0200, Krzysztof Kozlowski wrote: >>> DT schema expects panel timings node to follow certain pattern, >>> dtbs_check warnings: >>> >>> am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+' >>> >>> Linux drivers do not care about node name, so this should not have >>> effect on Linux. >>> >>> [...] >> >> 1.5 months on the lists, but maybe I combined too many separate TI maintainers, >> so no one feels responsible... then I guess I will take it. >> > > Yeah next time you should probably at least split omap and davinci > bits into separate patches. Otherwise I think Tony thought I'd pick it > up and vice versa. I guess after you acked it, Tony would pick it up. Anyway, please let me know if I should drop the patch / resend / split etc. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > On 26/06/2024 13:47, Bartosz Golaszewski wrote: >> On Wed, Jun 26, 2024 at 1:26 PM Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> >>> >>> On Thu, 09 May 2024 12:48:13 +0200, Krzysztof Kozlowski wrote: >>>> DT schema expects panel timings node to follow certain pattern, >>>> dtbs_check warnings: >>>> >>>> am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+' >>>> >>>> Linux drivers do not care about node name, so this should not have >>>> effect on Linux. >>>> >>>> [...] >>> >>> 1.5 months on the lists, but maybe I combined too many separate TI maintainers, >>> so no one feels responsible... then I guess I will take it. >>> >> >> Yeah next time you should probably at least split omap and davinci >> bits into separate patches. Otherwise I think Tony thought I'd pick it >> up and vice versa. > > I guess after you acked it, Tony would pick it up. > > Anyway, please let me know if I should drop the patch / resend / split etc. There's a bit of a handover transition as I take over from Tony on the omap stuff. Sorry for the lag, but thanks for picking this up. Kevin
On Thu, May 9, 2024 at 12:48 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> DT schema expects panel timings node to follow certain pattern,
> dtbs_check warnings:
>
> am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+'
>
> Linux drivers do not care about node name, so this should not have
> effect on Linux.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/ti/davinci/da850-evm.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/davinci/da850-evm.dts b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> index 6c5936278e75..1f5cd35f8b74 100644
> --- a/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> +++ b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> @@ -65,7 +65,7 @@ panel-info {
>
> display-timings {
> native-mode = <&timing0>;
> - timing0: 480x272 {
> + timing0: timing-480x272 {
> clock-frequency = <9000000>;
> hactive = <480>;
> vactive = <272>;
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> # For DaVinci
© 2016 - 2025 Red Hat, Inc.