[PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions()

Asbjørn Sloth Tønnesen posted 14 patches 1 year, 9 months ago
[PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions()
Posted by Asbjørn Sloth Tønnesen 1 year, 9 months ago
Convert DP_NOTICE/DP_INFO to NL_SET_ERR_MSG_MOD.

Keep edev around for use with QEDE_RSS_COUNT().

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
 drivers/net/ethernet/qlogic/qede/qede_filter.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index e616855d8891..9c72febc6a42 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -1671,7 +1671,7 @@ static int qede_parse_actions(struct qede_dev *edev,
 	int i;
 
 	if (!flow_action_has_entries(flow_action)) {
-		DP_NOTICE(edev, "No actions received\n");
+		NL_SET_ERR_MSG_MOD(extack, "No actions received");
 		return -EINVAL;
 	}
 
@@ -1687,7 +1687,8 @@ static int qede_parse_actions(struct qede_dev *edev,
 				break;
 
 			if (act->queue.index >= QEDE_RSS_COUNT(edev)) {
-				DP_INFO(edev, "Queue out-of-bounds\n");
+				NL_SET_ERR_MSG_MOD(extack,
+						   "Queue out-of-bounds");
 				return -EINVAL;
 			}
 			break;
-- 
2.43.0

Re: [PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions()
Posted by Simon Horman 1 year, 9 months ago
On Wed, May 08, 2024 at 02:34:02PM +0000, Asbjørn Sloth Tønnesen wrote:
> Convert DP_NOTICE/DP_INFO to NL_SET_ERR_MSG_MOD.
> 
> Keep edev around for use with QEDE_RSS_COUNT().
> 
> Only compile tested.
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Reviewed-by: Simon Horman <horms@kernel.org>