When processing a hardware update, HFI generates as many thermal netlink
events as needed to relay all the updated CPU capabilities to user space.
The constant HFI_MAX_THERM_NOTIFY_COUNT is the number of CPU capabilities
updated per each of those events.
Give this constant a more descriptive name.
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
Cc: Len Brown <len.brown@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Changes since v1:
* None
---
drivers/thermal/intel/intel_hfi.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
index d82b8788b0f8..c6658f8c5cca 100644
--- a/drivers/thermal/intel/intel_hfi.c
+++ b/drivers/thermal/intel/intel_hfi.c
@@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock);
static struct workqueue_struct *hfi_updates_wq;
#define HFI_UPDATE_DELAY_MS 100
-#define HFI_MAX_THERM_NOTIFY_COUNT 16
+#define HFI_THERMNL_CAPS_PER_EVENT 16
static void get_hfi_caps(struct hfi_instance *hfi_instance,
struct thermal_genl_cpu_caps *cpu_caps)
@@ -218,14 +218,14 @@ static void update_capabilities(struct hfi_instance *hfi_instance)
get_hfi_caps(hfi_instance, cpu_caps);
- if (cpu_count < HFI_MAX_THERM_NOTIFY_COUNT)
+ if (cpu_count < HFI_THERMNL_CAPS_PER_EVENT)
goto last_cmd;
- /* Process complete chunks of HFI_MAX_THERM_NOTIFY_COUNT capabilities. */
+ /* Process complete chunks of HFI_THERMNL_CAPS_PER_EVENT capabilities. */
for (i = 0;
- (i + HFI_MAX_THERM_NOTIFY_COUNT) <= cpu_count;
- i += HFI_MAX_THERM_NOTIFY_COUNT)
- thermal_genl_cpu_capability_event(HFI_MAX_THERM_NOTIFY_COUNT,
+ (i + HFI_THERMNL_CAPS_PER_EVENT) <= cpu_count;
+ i += HFI_THERMNL_CAPS_PER_EVENT)
+ thermal_genl_cpu_capability_event(HFI_THERMNL_CAPS_PER_EVENT,
&cpu_caps[i]);
cpu_count = cpu_count - i;
--
2.34.1
On Tue, 2024-05-07 at 20:43 -0700, Ricardo Neri wrote: > When processing a hardware update, HFI generates as many thermal > netlink > events as needed to relay all the updated CPU capabilities to user > space. > The constant HFI_MAX_THERM_NOTIFY_COUNT is the number of CPU > capabilities > updated per each of those events. > > Give this constant a more descriptive name. > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> -rui > --- > Cc: Len Brown <len.brown@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Changes since v1: > * None > --- > drivers/thermal/intel/intel_hfi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/intel/intel_hfi.c > b/drivers/thermal/intel/intel_hfi.c > index d82b8788b0f8..c6658f8c5cca 100644 > --- a/drivers/thermal/intel/intel_hfi.c > +++ b/drivers/thermal/intel/intel_hfi.c > @@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock); > > static struct workqueue_struct *hfi_updates_wq; > #define HFI_UPDATE_DELAY_MS 100 > -#define HFI_MAX_THERM_NOTIFY_COUNT 16 > +#define HFI_THERMNL_CAPS_PER_EVENT 16 > > static void get_hfi_caps(struct hfi_instance *hfi_instance, > struct thermal_genl_cpu_caps *cpu_caps) > @@ -218,14 +218,14 @@ static void update_capabilities(struct > hfi_instance *hfi_instance) > > get_hfi_caps(hfi_instance, cpu_caps); > > - if (cpu_count < HFI_MAX_THERM_NOTIFY_COUNT) > + if (cpu_count < HFI_THERMNL_CAPS_PER_EVENT) > goto last_cmd; > > - /* Process complete chunks of HFI_MAX_THERM_NOTIFY_COUNT > capabilities. */ > + /* Process complete chunks of HFI_THERMNL_CAPS_PER_EVENT > capabilities. */ > for (i = 0; > - (i + HFI_MAX_THERM_NOTIFY_COUNT) <= cpu_count; > - i += HFI_MAX_THERM_NOTIFY_COUNT) > - > thermal_genl_cpu_capability_event(HFI_MAX_THERM_NOTIFY_ > COUNT, > + (i + HFI_THERMNL_CAPS_PER_EVENT) <= cpu_count; > + i += HFI_THERMNL_CAPS_PER_EVENT) > + thermal_genl_cpu_capability_event(HFI_THERMNL_CAPS_PE > R_EVENT, > &cpu_caps[i]); > > cpu_count = cpu_count - i;
© 2016 - 2025 Red Hat, Inc.