[PATCH] s390: Remove comment about TIF_FPU

Thomas Huth posted 1 patch 1 year, 7 months ago
There is a newer version of this series
arch/s390/kernel/process.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] s390: Remove comment about TIF_FPU
Posted by Thomas Huth 1 year, 7 months ago
It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
so we should not mention TIF_FPU in the comment here anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 arch/s390/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
index dd456b475861..3e7df2e579f1 100644
--- a/arch/s390/kernel/process.c
+++ b/arch/s390/kernel/process.c
@@ -88,8 +88,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
 {
 	/*
 	 * Save the floating-point or vector register state of the current
-	 * task and set the TIF_FPU flag to lazy restore the FPU register
-	 * state when returning to user space.
+	 * task.
 	 */
 	save_user_fpu_regs();
 
-- 
2.44.0
Re: [PATCH] s390: Remove comment about TIF_FPU
Posted by Heiko Carstens 1 year, 7 months ago
On Thu, May 02, 2024 at 07:25:27PM +0200, Thomas Huth wrote:
> It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
> so we should not mention TIF_FPU in the comment here anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  arch/s390/kernel/process.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
> index dd456b475861..3e7df2e579f1 100644
> --- a/arch/s390/kernel/process.c
> +++ b/arch/s390/kernel/process.c
> @@ -88,8 +88,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
>  {
>  	/*
>  	 * Save the floating-point or vector register state of the current
> -	 * task and set the TIF_FPU flag to lazy restore the FPU register
> -	 * state when returning to user space.
> +	 * task.
>  	 */
>  	save_user_fpu_regs();

Could you change your patch to remove the whole comment instead, please?

Without the TIF_FPU part the comment becomes quite pointless, since it
only documents the obvious.