selftests: cgroup: remove redundant addition of memory controller

[PATCH] selftests: cgroup: remove redundant addition of memory controller

Usama Arif posted 1 patch 1 year, 7 months ago

Download mbox

tools/testing/selftests/cgroup/test_zswap.c | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH] selftests: cgroup: remove redundant addition of memory controller

Posted by Usama Arif 1 year, 7 months ago

This is already done in main.

Signed-off-by: Usama Arif <usamaarif642@gmail.com>
---
 tools/testing/selftests/cgroup/test_zswap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
index fe0e7221525c..22cf586d2438 100644
--- a/tools/testing/selftests/cgroup/test_zswap.c
+++ b/tools/testing/selftests/cgroup/test_zswap.c
@@ -445,8 +445,6 @@ static int test_no_kmem_bypass(const char *root)
 	trigger_allocation_size = sys_info.totalram / 20;
 
 	/* Set up test memcg */
-	if (cg_write(root, "cgroup.subtree_control", "+memory"))
-		goto out;
 	test_group = cg_name(root, "kmem_bypass_test");
 	if (!test_group)
 		goto out;
-- 
2.43.0

Re: [PATCH] selftests: cgroup: remove redundant addition of memory controller

Posted by Markus Elfring 1 year, 7 months ago

> This is already done in main.

Please improve this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n45

Will the tag “Fixes” become relevant here (besides an imperative wording)?

Regards,
Markus