arm64: dts: qcom: fix PHY-related warnings

[PATCH 04/13] arm64: dts: qcom: sc7180: drop extra UFS PHY compat

Posted by Dmitry Baryshkov 1 year, 7 months ago

The DT schema doesn't have a fallback compatible for
qcom,sc7180-qmp-ufs-phy. Drop it from the dtsi too.

Fixes: 858536d9dc94 ("arm64: dts: qcom: sc7180: Add UFS nodes")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 4774a859bd7e..52d074a4fbf3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1582,8 +1582,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 		};
 
 		ufs_mem_phy: phy@1d87000 {
-			compatible = "qcom,sc7180-qmp-ufs-phy",
-				     "qcom,sm7150-qmp-ufs-phy";
+			compatible = "qcom,sc7180-qmp-ufs-phy";
 			reg = <0 0x01d87000 0 0x1000>;
 			clocks = <&rpmhcc RPMH_CXO_CLK>,
 				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,

-- 
2.39.2

Re: [PATCH 04/13] arm64: dts: qcom: sc7180: drop extra UFS PHY compat

Posted by Doug Anderson 1 year, 7 months ago

Hi,

On Wed, May 1, 2024 at 9:19 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> The DT schema doesn't have a fallback compatible for
> qcom,sc7180-qmp-ufs-phy. Drop it from the dtsi too.
>
> Fixes: 858536d9dc94 ("arm64: dts: qcom: sc7180: Add UFS nodes")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 4774a859bd7e..52d074a4fbf3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1582,8 +1582,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>                 };
>
>                 ufs_mem_phy: phy@1d87000 {
> -                       compatible = "qcom,sc7180-qmp-ufs-phy",
> -                                    "qcom,sm7150-qmp-ufs-phy";
> +                       compatible = "qcom,sc7180-qmp-ufs-phy";

Seems OK to me. It looks like UFS support for sc7180 is new enough
that we're not breaking any sort of compatbility by changing this.

Reviewed-by: Douglas Anderson <dianders@chromium.org>