ARM: dts: BCM5301X: Fix PCIe controller warnings

[PATCH 0/2] ARM: dts: BCM5301X: Fix PCIe controller warnings

Posted by Florian Fainelli 1 year, 7 months ago

Hi Rafal,

Here is a counter proposal to your patch series:

https://lore.kernel.org/all/20240423110238.32148-1-zajec5@gmail.com/

which is a little bit smaller in terms of lines changed. Note that with
either my patches or yours, we still have the following warnings show
up:

arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts:133.15-145.4:
Warning (pci_device_reg): /axi@18000000/pcie@18012000/bridge@0,0,0: PCI
unit address format error, expected "0,0"
arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts:152.15-191.4:
Warning (pci_device_reg): /axi@18000000/pcie@18013000/bridge@1,0,0: PCI
unit address format error, expected "0,0"

Thanks!

Florian Fainelli (1):
  ARM: dts: BCM5301X: Relocate PCIe nodes to top-level

Rafał Miłecki (1):
  ARM: dts: BCM5301X: Describe PCIe controllers fully

 arch/arm/boot/dts/broadcom/bcm-ns.dtsi | 97 +++++++++++++++-----------
 1 file changed, 58 insertions(+), 39 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] ARM: dts: BCM5301X: Fix PCIe controller warnings

Posted by Florian Fainelli 1 year, 6 months ago

On 4/30/24 16:07, Florian Fainelli wrote:
> Hi Rafal,
> 
> Here is a counter proposal to your patch series:
> 
> https://lore.kernel.org/all/20240423110238.32148-1-zajec5@gmail.com/
> 
> which is a little bit smaller in terms of lines changed. Note that with
> either my patches or yours, we still have the following warnings show
> up:
> 
> arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts:133.15-145.4:
> Warning (pci_device_reg): /axi@18000000/pcie@18012000/bridge@0,0,0: PCI
> unit address format error, expected "0,0"
> arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts:152.15-191.4:
> Warning (pci_device_reg): /axi@18000000/pcie@18013000/bridge@1,0,0: PCI
> unit address format error, expected "0,0"

Rafal, any chance you could test those patches? Thanks

> 
> Thanks!
> 
> Florian Fainelli (1):
>    ARM: dts: BCM5301X: Relocate PCIe nodes to top-level
> 
> Rafał Miłecki (1):
>    ARM: dts: BCM5301X: Describe PCIe controllers fully
> 
>   arch/arm/boot/dts/broadcom/bcm-ns.dtsi | 97 +++++++++++++++-----------
>   1 file changed, 58 insertions(+), 39 deletions(-)
> 

-- 
Florian