1. Patchew
  2. linux
  3. [PATCH V3 0/8] Add support for videocc and camcc on SM8650
  4. View patch

[PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header

Jagadeesh Kona posted 8 patches 1 year, 7 months ago
There is a newer version of this series
[PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header
Posted by Jagadeesh Kona 1 year, 7 months ago 
Fix the incorrect order of SC8280XP camcc header file in SM8450 camcc
bindings.

Fixes: 206cd759fbd2 ("dt-bindings: clock: Add SC8280XP CAMCC")
Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index fa0e5b6b02b8..bf23e25d71f5 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -14,9 +14,9 @@ description: |
   domains on SM8450.
 
   See also::
+    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
     include/dt-bindings/clock/qcom,sm8450-camcc.h
     include/dt-bindings/clock/qcom,sm8550-camcc.h
-    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
     include/dt-bindings/clock/qcom,x1e80100-camcc.h
 
 allOf:
-- 
2.43.0
Re: [PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header
Posted by Bryan O'Donoghue 1 year, 7 months ago 
On 30/04/2024 15:27, Jagadeesh Kona wrote:
> Fix the incorrect order of SC8280XP camcc header file in SM8450 camcc
> bindings.
> 
> Fixes: 206cd759fbd2 ("dt-bindings: clock: Add SC8280XP CAMCC")
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
>   Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> index fa0e5b6b02b8..bf23e25d71f5 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> @@ -14,9 +14,9 @@ description: |
>     domains on SM8450.
>   
>     See also::
> +    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>       include/dt-bindings/clock/qcom,sm8450-camcc.h
>       include/dt-bindings/clock/qcom,sm8550-camcc.h
> -    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>       include/dt-bindings/clock/qcom,x1e80100-camcc.h
>   
>   allOf:

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Re: [PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header
Posted by Johan Hovold 1 year, 7 months ago 
On Tue, Apr 30, 2024 at 07:57:54PM +0530, Jagadeesh Kona wrote:
> Fix the incorrect order of SC8280XP camcc header file in SM8450 camcc
> bindings.

Try to avoid using the word "fix" in the commit summary (Subject) and
commit message for things like this which are essentially cleanups to
avoid making it sound like a bug fix (which automated tooling may then
select for backporting).
 
> Fixes: 206cd759fbd2 ("dt-bindings: clock: Add SC8280XP CAMCC")

Also drop the Fixes tag as this is not a bug fix.

> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> index fa0e5b6b02b8..bf23e25d71f5 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> @@ -14,9 +14,9 @@ description: |
>    domains on SM8450.
>  
>    See also::
> +    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>      include/dt-bindings/clock/qcom,sm8450-camcc.h
>      include/dt-bindings/clock/qcom,sm8550-camcc.h
> -    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>      include/dt-bindings/clock/qcom,x1e80100-camcc.h

Johan
Re: [PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header
Posted by Jagadeesh Kona 1 year, 7 months ago 

On 5/1/2024 12:13 PM, Johan Hovold wrote:
> On Tue, Apr 30, 2024 at 07:57:54PM +0530, Jagadeesh Kona wrote:
>> Fix the incorrect order of SC8280XP camcc header file in SM8450 camcc
>> bindings.
> 
> Try to avoid using the word "fix" in the commit summary (Subject) and
> commit message for things like this which are essentially cleanups to
> avoid making it sound like a bug fix (which automated tooling may then
> select for backporting).
>   

Thanks Johan for your review!

Yes, will remove the word "fix" in commit subject and message.

>> Fixes: 206cd759fbd2 ("dt-bindings: clock: Add SC8280XP CAMCC")
> 
> Also drop the Fixes tag as this is not a bug fix.
> 

Sure, will drop Fixes tag in next series.

Thanks,
Jagadeesh

>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
>> index fa0e5b6b02b8..bf23e25d71f5 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
>> @@ -14,9 +14,9 @@ description: |
>>     domains on SM8450.
>>   
>>     See also::
>> +    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>>       include/dt-bindings/clock/qcom,sm8450-camcc.h
>>       include/dt-bindings/clock/qcom,sm8550-camcc.h
>> -    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>>       include/dt-bindings/clock/qcom,x1e80100-camcc.h
> 
> Johan

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.