HID: i2c-hid: Unify device wake-up logic

[PATCH 0/2] HID: i2c-hid: Unify device wake-up logic

Posted by Kenny Levinsen 1 year, 7 months ago

Third time was not the charm[0]. After Dmitry's comment[1], and after
looking some more at the I2C drivers, I have given up on removing the
smbus probe for now. We can always revisit this later if the situation
improves enough, but there are more important things to fix.

Instead, go all in on the address probe with retry and use it for both
initial probe and resume, replacing the previous retry on power on
commands. This gives us consistency and a single place to update and
document.

[0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/
[1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/

Re: [PATCH 0/2] HID: i2c-hid: Unify device wake-up logic

Posted by Jiri Kosina 1 year, 7 months ago

On Tue, 30 Apr 2024, Kenny Levinsen wrote:

> Third time was not the charm[0]. After Dmitry's comment[1], and after
> looking some more at the I2C drivers, I have given up on removing the
> smbus probe for now. We can always revisit this later if the situation
> improves enough, but there are more important things to fix.
> 
> Instead, go all in on the address probe with retry and use it for both
> initial probe and resume, replacing the previous retry on power on
> commands. This gives us consistency and a single place to update and
> document.
> 
> [0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/
> [1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/

I really apologize for belated response to all this, I've been completely 
swamped for the past two weeks.

This is now queued in hid.git#for-6.10/i2c-hid.

Thanks,

-- 
Jiri Kosina
SUSE Labs