The else clause after the ruturn clause is not useful.

Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 3574681891e8..433572c4caf9 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
 
 	if (!strcmp(id->name, "sf-tc240t-9370-t"))
 		return ili9341_dpi_probe(spi, dc, reset);
-	else if (!strcmp(id->name, "yx240qv29"))
+
+	if (!strcmp(id->name, "yx240qv29"))
 		return ili9341_dbi_probe(spi, dc, reset);
 
 	return -1;
-- 
2.34.1

On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
> The else clause after the ruturn clause is not useful.

Hi Sui,

Spelling nit: ruturn --> return

Besides that,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> 
> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
> ---
>   drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index 3574681891e8..433572c4caf9 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
>   
>   	if (!strcmp(id->name, "sf-tc240t-9370-t"))
>   		return ili9341_dpi_probe(spi, dc, reset);
> -	else if (!strcmp(id->name, "yx240qv29"))
> +
> +	if (!strcmp(id->name, "yx240qv29"))
>   		return ili9341_dbi_probe(spi, dc, reset);
>   
>   	return -1;
> -- 
> 2.34.1
>

Hi,


On 2024/4/30 07:10, Jessica Zhang wrote:
>
>
> On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
>> The else clause after the ruturn clause is not useful.
>
> Hi Sui,
>
> Spelling nit: ruturn --> return
>

Thanks for pointed out, will be fixed.


> Besides that,
>
> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>
> Thanks,
>
> Jessica Zhang


Thanks, Jessica.