1. Patchew
  2. linux
  3. [PATCH v10 0/6] Add interconnect driver for IPQ9574 SoC
  4. View patch

[PATCH v10 2/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support

Varadarajan Narayanan posted 6 patches 1 year, 7 months ago
There is a newer version of this series
[PATCH v10 2/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support
Posted by Varadarajan Narayanan 1 year, 7 months ago 
Add interconnect-cells to clock provider so that it can be
used as icc provider.

Add master/slave ids for Qualcomm IPQ9574 Network-On-Chip
interfaces. This will be used by the gcc-ipq9574 driver
that will for providing interconnect services using the
icc-clk framework.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
v8:
Remove ICC_xxx macros
Fix macro defines to be consistent with other bindings
v7:
Fix macro names to be consistent with other bindings
v6:
Removed Reviewed-by: Krzysztof Kozlowski
Redefine the bindings such that driver and DT can share them

v3:
Squash Documentation/ and include/ changes into same patch

qcom,ipq9574.h
	Move 'first id' to clock driver

---
 .../bindings/clock/qcom,ipq9574-gcc.yaml      |  3 +
 .../dt-bindings/interconnect/qcom,ipq9574.h   | 59 +++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 include/dt-bindings/interconnect/qcom,ipq9574.h

diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
index 944a0ea79cd6..824781cbdf34 100644
--- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
@@ -33,6 +33,9 @@ properties:
       - description: PCIE30 PHY3 pipe clock source
       - description: USB3 PHY pipe clock source
 
+  '#interconnect-cells':
+    const: 1
+
 required:
   - compatible
   - clocks
diff --git a/include/dt-bindings/interconnect/qcom,ipq9574.h b/include/dt-bindings/interconnect/qcom,ipq9574.h
new file mode 100644
index 000000000000..42019335c7dd
--- /dev/null
+++ b/include/dt-bindings/interconnect/qcom,ipq9574.h
@@ -0,0 +1,59 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+#ifndef INTERCONNECT_QCOM_IPQ9574_H
+#define INTERCONNECT_QCOM_IPQ9574_H
+
+#define MASTER_ANOC_PCIE0		0
+#define SLAVE_ANOC_PCIE0		1
+#define MASTER_SNOC_PCIE0		2
+#define SLAVE_SNOC_PCIE0		3
+#define MASTER_ANOC_PCIE1		4
+#define SLAVE_ANOC_PCIE1		5
+#define MASTER_SNOC_PCIE1		6
+#define SLAVE_SNOC_PCIE1		7
+#define MASTER_ANOC_PCIE2		8
+#define SLAVE_ANOC_PCIE2		9
+#define MASTER_SNOC_PCIE2		10
+#define SLAVE_SNOC_PCIE2		11
+#define MASTER_ANOC_PCIE3		12
+#define SLAVE_ANOC_PCIE3		13
+#define MASTER_SNOC_PCIE3		14
+#define SLAVE_SNOC_PCIE3		15
+#define MASTER_USB			16
+#define SLAVE_USB			17
+#define MASTER_USB_AXI			18
+#define SLAVE_USB_AXI			19
+#define MASTER_NSSNOC_NSSCC		20
+#define SLAVE_NSSNOC_NSSCC		21
+#define MASTER_NSSNOC_SNOC_0		22
+#define SLAVE_NSSNOC_SNOC_0		23
+#define MASTER_NSSNOC_SNOC_1		24
+#define SLAVE_NSSNOC_SNOC_1		25
+#define MASTER_NSSNOC_PCNOC_1		26
+#define SLAVE_NSSNOC_PCNOC_1		27
+#define MASTER_NSSNOC_QOSGEN_REF	28
+#define SLAVE_NSSNOC_QOSGEN_REF		29
+#define MASTER_NSSNOC_TIMEOUT_REF	30
+#define SLAVE_NSSNOC_TIMEOUT_REF	31
+#define MASTER_NSSNOC_XO_DCD		32
+#define SLAVE_NSSNOC_XO_DCD		33
+#define MASTER_NSSNOC_ATB		34
+#define SLAVE_NSSNOC_ATB		35
+#define MASTER_MEM_NOC_NSSNOC		36
+#define SLAVE_MEM_NOC_NSSNOC		37
+#define MASTER_NSSNOC_MEMNOC		38
+#define SLAVE_NSSNOC_MEMNOC		39
+#define MASTER_NSSNOC_MEM_NOC_1		40
+#define SLAVE_NSSNOC_MEM_NOC_1		41
+
+#define MASTER_NSSNOC_PPE		0
+#define SLAVE_NSSNOC_PPE		1
+#define MASTER_NSSNOC_PPE_CFG		2
+#define SLAVE_NSSNOC_PPE_CFG		3
+#define MASTER_NSSNOC_NSS_CSR		4
+#define SLAVE_NSSNOC_NSS_CSR		5
+#define MASTER_NSSNOC_IMEM_QSB		6
+#define SLAVE_NSSNOC_IMEM_QSB		7
+#define MASTER_NSSNOC_IMEM_AHB		8
+#define SLAVE_NSSNOC_IMEM_AHB		9
+
+#endif /* INTERCONNECT_QCOM_IPQ9574_H */
-- 
2.34.1
Re: [PATCH v10 2/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support
Posted by Georgi Djakov 1 year, 7 months ago 
On 29.04.24 12:13, Varadarajan Narayanan wrote:
> Add interconnect-cells to clock provider so that it can be
> used as icc provider.
> 
> Add master/slave ids for Qualcomm IPQ9574 Network-On-Chip
> interfaces. This will be used by the gcc-ipq9574 driver
> that will for providing interconnect services using the
> icc-clk framework.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>

Acked-by: Georgi Djakov <djakov@kernel.org>

> ---
> v8:
> Remove ICC_xxx macros
> Fix macro defines to be consistent with other bindings
> v7:
> Fix macro names to be consistent with other bindings
> v6:
> Removed Reviewed-by: Krzysztof Kozlowski
> Redefine the bindings such that driver and DT can share them
> 
> v3:
> Squash Documentation/ and include/ changes into same patch
> 
> qcom,ipq9574.h
> 	Move 'first id' to clock driver
> 
> ---
>   .../bindings/clock/qcom,ipq9574-gcc.yaml      |  3 +
>   .../dt-bindings/interconnect/qcom,ipq9574.h   | 59 +++++++++++++++++++
>   2 files changed, 62 insertions(+)
>   create mode 100644 include/dt-bindings/interconnect/qcom,ipq9574.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
> index 944a0ea79cd6..824781cbdf34 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
> @@ -33,6 +33,9 @@ properties:
>         - description: PCIE30 PHY3 pipe clock source
>         - description: USB3 PHY pipe clock source
>   
> +  '#interconnect-cells':
> +    const: 1
> +
>   required:
>     - compatible
>     - clocks
> diff --git a/include/dt-bindings/interconnect/qcom,ipq9574.h b/include/dt-bindings/interconnect/qcom,ipq9574.h
> new file mode 100644
> index 000000000000..42019335c7dd
> --- /dev/null
> +++ b/include/dt-bindings/interconnect/qcom,ipq9574.h
> @@ -0,0 +1,59 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +#ifndef INTERCONNECT_QCOM_IPQ9574_H
> +#define INTERCONNECT_QCOM_IPQ9574_H
> +
> +#define MASTER_ANOC_PCIE0		0
> +#define SLAVE_ANOC_PCIE0		1
> +#define MASTER_SNOC_PCIE0		2
> +#define SLAVE_SNOC_PCIE0		3
> +#define MASTER_ANOC_PCIE1		4
> +#define SLAVE_ANOC_PCIE1		5
> +#define MASTER_SNOC_PCIE1		6
> +#define SLAVE_SNOC_PCIE1		7
> +#define MASTER_ANOC_PCIE2		8
> +#define SLAVE_ANOC_PCIE2		9
> +#define MASTER_SNOC_PCIE2		10
> +#define SLAVE_SNOC_PCIE2		11
> +#define MASTER_ANOC_PCIE3		12
> +#define SLAVE_ANOC_PCIE3		13
> +#define MASTER_SNOC_PCIE3		14
> +#define SLAVE_SNOC_PCIE3		15
> +#define MASTER_USB			16
> +#define SLAVE_USB			17
> +#define MASTER_USB_AXI			18
> +#define SLAVE_USB_AXI			19
> +#define MASTER_NSSNOC_NSSCC		20
> +#define SLAVE_NSSNOC_NSSCC		21
> +#define MASTER_NSSNOC_SNOC_0		22
> +#define SLAVE_NSSNOC_SNOC_0		23
> +#define MASTER_NSSNOC_SNOC_1		24
> +#define SLAVE_NSSNOC_SNOC_1		25
> +#define MASTER_NSSNOC_PCNOC_1		26
> +#define SLAVE_NSSNOC_PCNOC_1		27
> +#define MASTER_NSSNOC_QOSGEN_REF	28
> +#define SLAVE_NSSNOC_QOSGEN_REF		29
> +#define MASTER_NSSNOC_TIMEOUT_REF	30
> +#define SLAVE_NSSNOC_TIMEOUT_REF	31
> +#define MASTER_NSSNOC_XO_DCD		32
> +#define SLAVE_NSSNOC_XO_DCD		33
> +#define MASTER_NSSNOC_ATB		34
> +#define SLAVE_NSSNOC_ATB		35
> +#define MASTER_MEM_NOC_NSSNOC		36
> +#define SLAVE_MEM_NOC_NSSNOC		37
> +#define MASTER_NSSNOC_MEMNOC		38
> +#define SLAVE_NSSNOC_MEMNOC		39
> +#define MASTER_NSSNOC_MEM_NOC_1		40
> +#define SLAVE_NSSNOC_MEM_NOC_1		41
> +
> +#define MASTER_NSSNOC_PPE		0
> +#define SLAVE_NSSNOC_PPE		1
> +#define MASTER_NSSNOC_PPE_CFG		2
> +#define SLAVE_NSSNOC_PPE_CFG		3
> +#define MASTER_NSSNOC_NSS_CSR		4
> +#define SLAVE_NSSNOC_NSS_CSR		5
> +#define MASTER_NSSNOC_IMEM_QSB		6
> +#define SLAVE_NSSNOC_IMEM_QSB		7
> +#define MASTER_NSSNOC_IMEM_AHB		8
> +#define SLAVE_NSSNOC_IMEM_AHB		9
> +
> +#endif /* INTERCONNECT_QCOM_IPQ9574_H */

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.