[v1] iio: adc: ad799x: Fix warning generated by checkpatch

[PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch

Posted by ogustavo@usp.br 2 weeks, 6 days ago

From: Gustavo Rodrigues <ogustavo@usp.br>

Clean code of iio:adc:ad799x to cease warning messages pointed by
checkpatch. These include proper variable declaration 'unsigned' to 
'unsigned int', add blank line and use of octal permission instead of 
symbolic.

Gustavo (3):
  iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
  iio: adc: ad799x.c: add blank line to avoid warning messages
  iio: adc: ad799x: Prefer to use octal permission instead of symbolic

 drivers/iio/adc/ad799x.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.34.1

Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch

Posted by Nuno Sá 2 weeks, 6 days ago

On Sun, 2024-04-28 at 16:43 -0300, ogustavo@usp.br wrote:
> From: Gustavo Rodrigues <ogustavo@usp.br>
> 
> Clean code of iio:adc:ad799x to cease warning messages pointed by
> checkpatch. These include proper variable declaration 'unsigned' to 
> 'unsigned int', add blank line and use of octal permission instead of 
> symbolic.
> 
> Gustavo (3):
>   iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
>   iio: adc: ad799x.c: add blank line to avoid warning messages
>   iio: adc: ad799x: Prefer to use octal permission instead of symbolic
> 
>  drivers/iio/adc/ad799x.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Patches look good. Just one note... It seems Marcelo gave some feedback on a
previous iterations so it looks like this should have been marked as v2?

Anyways,

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch

Posted by Jonathan Cameron 2 weeks, 5 days ago

On Mon, 29 Apr 2024 09:28:25 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Sun, 2024-04-28 at 16:43 -0300, ogustavo@usp.br wrote:
> > From: Gustavo Rodrigues <ogustavo@usp.br>
> > 
> > Clean code of iio:adc:ad799x to cease warning messages pointed by
> > checkpatch. These include proper variable declaration 'unsigned' to 
> > 'unsigned int', add blank line and use of octal permission instead of 
> > symbolic.
> > 
> > Gustavo (3):
> >   iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
> >   iio: adc: ad799x.c: add blank line to avoid warning messages
> >   iio: adc: ad799x: Prefer to use octal permission instead of symbolic
> > 
> >  drivers/iio/adc/ad799x.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >   
> 
> Patches look good. Just one note... It seems Marcelo gave some feedback on a
> previous iterations so it looks like this should have been marked as v2?
> 
> Anyways,
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> 

Indeed on v2.  Anyhow, applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to see if we missed anything,

Thanks,

Jonathan