proc: Remove unnecessary interrupts.c include

[PATCH -next] proc: Remove unnecessary interrupts.c include

Posted by Jinjie Ruan 1 year, 7 months ago

The irqnr.h is included in interrupts.h and the fs.h is included in
proc_fs.h, they are unnecessary included in interrupts.c, so remove it.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 fs/proc/interrupts.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/proc/interrupts.c b/fs/proc/interrupts.c
index cb0edc7cbf09..463a0f754edf 100644
--- a/fs/proc/interrupts.c
+++ b/fs/proc/interrupts.c
@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
-#include <linux/fs.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
-#include <linux/irqnr.h>
 #include <linux/proc_fs.h>
 #include <linux/seq_file.h>
 
-- 
2.34.1

Re: [PATCH -next] proc: Remove unnecessary interrupts.c include

Posted by Andrew Morton 1 year, 7 months ago

On Sun, 28 Apr 2024 17:48:47 +0800 Jinjie Ruan <ruanjinjie@huawei.com> wrote:

> The irqnr.h is included in interrupts.h and the fs.h is included in
> proc_fs.h, they are unnecessary included in interrupts.c, so remove it.
> 
> ...
>
> --- a/fs/proc/interrupts.c
> +++ b/fs/proc/interrupts.c
> @@ -1,8 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
> -#include <linux/fs.h>
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
> -#include <linux/irqnr.h>
>  #include <linux/proc_fs.h>
>  #include <linux/seq_file.h>

Within limits, we prefer that .c files directly include the headers
which they use.  If interrupts.c uses nothing from these headers then
OK.  If, however, interrupts.c does use things which are defined in
these headers then the inclusion of those headers is desired.

Re: [PATCH -next] proc: Remove unnecessary interrupts.c include

Posted by Jinjie Ruan 1 year, 7 months ago


On 2024/4/30 0:35, Andrew Morton wrote:
> On Sun, 28 Apr 2024 17:48:47 +0800 Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> 
>> The irqnr.h is included in interrupts.h and the fs.h is included in
>> proc_fs.h, they are unnecessary included in interrupts.c, so remove it.
>>
>> ...
>>
>> --- a/fs/proc/interrupts.c
>> +++ b/fs/proc/interrupts.c
>> @@ -1,8 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>> -#include <linux/fs.h>
>>  #include <linux/init.h>
>>  #include <linux/interrupt.h>
>> -#include <linux/irqnr.h>
>>  #include <linux/proc_fs.h>
>>  #include <linux/seq_file.h>
> 
> Within limits, we prefer that .c files directly include the headers
> which they use.  If interrupts.c uses nothing from these headers then
> OK.  If, however, interrupts.c does use things which are defined in
> these headers then the inclusion of those headers is desired.

Thank you, sorry I'm just learning the rules now.