[v3] Fix Kernel CI issues

[PATCH v3 0/2] Fix Kernel CI issues

Posted by Anatoliy Klymenko 1 year, 9 months ago

Fix number of CI reported W=1 build issues.

Patch 1/2: Fix function arguments description.
Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.KFGDpCDN-lkp@intel.com/

Patch 2/2: Fix clang compilation error.
Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-lkp@intel.com/

Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
---
Changes in v3:
- Add Signed-off-by tag.

- Link to v2: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v2-0-6048e81211de@amd.com

Changes in v2:
- Compilation error fix added.

- Link to v1: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v1-1-405f352d3485@amd.com

---
Anatoliy Klymenko (2):
      drm: xlnx: zynqmp_dpsub: Fix few function comments
      drm: xlnx: zynqmp_dpsub: Fix compilation error

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f
change-id: 20240425-dp-live-fmt-fix-a10bf7973596

Best regards,
-- 
Anatoliy Klymenko <anatoliy.klymenko@amd.com>

Re: [PATCH v3 0/2] Fix Kernel CI issues

Posted by Tomi Valkeinen 1 year, 9 months ago

On 26/04/2024 22:27, Anatoliy Klymenko wrote:
> Fix number of CI reported W=1 build issues.
> 
> Patch 1/2: Fix function arguments description.
> Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.KFGDpCDN-lkp@intel.com/
> 
> Patch 2/2: Fix clang compilation error.
> Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-lkp@intel.com/
> 
> Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
> ---
> Changes in v3:
> - Add Signed-off-by tag.
> 
> - Link to v2: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v2-0-6048e81211de@amd.com
> 
> Changes in v2:
> - Compilation error fix added.
> 
> - Link to v1: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v1-1-405f352d3485@amd.com
> 
> ---
> Anatoliy Klymenko (2):
>        drm: xlnx: zynqmp_dpsub: Fix few function comments
>        drm: xlnx: zynqmp_dpsub: Fix compilation error
> 
>   drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> ---
> base-commit: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f
> change-id: 20240425-dp-live-fmt-fix-a10bf7973596
> 
> Best regards,

Thanks, pushed to drm-misc-next.

  Tomi

Re: [PATCH v3 0/2] Fix Kernel CI issues

Posted by Nathan Chancellor 1 year, 9 months ago

Hi Tomi,

On Sat, Apr 27, 2024 at 10:48:16AM +0300, Tomi Valkeinen wrote:
> On 26/04/2024 22:27, Anatoliy Klymenko wrote:
> > Fix number of CI reported W=1 build issues.
> > 
> > Patch 1/2: Fix function arguments description.
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.KFGDpCDN-lkp@intel.com/
> > 
> > Patch 2/2: Fix clang compilation error.
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-lkp@intel.com/
> > 
> > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
> > ---
> > Changes in v3:
> > - Add Signed-off-by tag.
> > 
> > - Link to v2: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v2-0-6048e81211de@amd.com
> > 
> > Changes in v2:
> > - Compilation error fix added.
> > 
> > - Link to v1: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v1-1-405f352d3485@amd.com
> > 
> > ---
> > Anatoliy Klymenko (2):
> >        drm: xlnx: zynqmp_dpsub: Fix few function comments
> >        drm: xlnx: zynqmp_dpsub: Fix compilation error
> > 
> >   drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > ---
> > base-commit: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f
> > change-id: 20240425-dp-live-fmt-fix-a10bf7973596
> > 
> > Best regards,
> 
> Thanks, pushed to drm-misc-next.

I think the second patch also needs to go to drm-misc-next-fixes? The
clang warning fixed by it has returned in next-20240503 because it
appears that for-linux-next was switch from drm-misc-next to
drm-misc-next-fixes, as I see for-linux-next was pointing to commit
235e60653f8d ("drm/debugfs: Drop conditionals around of_node pointers")
on drm-misc-next in next-20240502 but it is now pointing to commit
be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") on
drm-misc-next-fixes in next-20240503.

Cheers,
Nathan

Re: [PATCH v3 0/2] Fix Kernel CI issues

Posted by Tomi Valkeinen 1 year, 9 months ago

On 03/05/2024 19:27, Nathan Chancellor wrote:
> Hi Tomi,
> 
> On Sat, Apr 27, 2024 at 10:48:16AM +0300, Tomi Valkeinen wrote:
>> On 26/04/2024 22:27, Anatoliy Klymenko wrote:
>>> Fix number of CI reported W=1 build issues.
>>>
>>> Patch 1/2: Fix function arguments description.
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.KFGDpCDN-lkp@intel.com/
>>>
>>> Patch 2/2: Fix clang compilation error.
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-lkp@intel.com/
>>>
>>> Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
>>> ---
>>> Changes in v3:
>>> - Add Signed-off-by tag.
>>>
>>> - Link to v2: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v2-0-6048e81211de@amd.com
>>>
>>> Changes in v2:
>>> - Compilation error fix added.
>>>
>>> - Link to v1: https://lore.kernel.org/r/20240425-dp-live-fmt-fix-v1-1-405f352d3485@amd.com
>>>
>>> ---
>>> Anatoliy Klymenko (2):
>>>         drm: xlnx: zynqmp_dpsub: Fix few function comments
>>>         drm: xlnx: zynqmp_dpsub: Fix compilation error
>>>
>>>    drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>> ---
>>> base-commit: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f
>>> change-id: 20240425-dp-live-fmt-fix-a10bf7973596
>>>
>>> Best regards,
>>
>> Thanks, pushed to drm-misc-next.
> 
> I think the second patch also needs to go to drm-misc-next-fixes? The
> clang warning fixed by it has returned in next-20240503 because it
> appears that for-linux-next was switch from drm-misc-next to
> drm-misc-next-fixes, as I see for-linux-next was pointing to commit
> 235e60653f8d ("drm/debugfs: Drop conditionals around of_node pointers")
> on drm-misc-next in next-20240502 but it is now pointing to commit
> be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") on
> drm-misc-next-fixes in next-20240503.

Oh. Hmm, did I just hit the feature-freeze point with the fixes...

Now I'm unsure where I should push these (if anywhere), as they already 
are in drm-misc-next.

DRM Misc maintainers, can you give me a hint? =)

  Tomi

Re: [PATCH v3 0/2] Fix Kernel CI issues

Posted by Jakub Kicinski 1 year, 8 months ago

On Fri, 3 May 2024 20:25:49 +0300 Tomi Valkeinen wrote:
> > I think the second patch also needs to go to drm-misc-next-fixes? The
> > clang warning fixed by it has returned in next-20240503 because it
> > appears that for-linux-next was switch from drm-misc-next to
> > drm-misc-next-fixes, as I see for-linux-next was pointing to commit
> > 235e60653f8d ("drm/debugfs: Drop conditionals around of_node pointers")
> > on drm-misc-next in next-20240502 but it is now pointing to commit
> > be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") on
> > drm-misc-next-fixes in next-20240503.  
> 
> Oh. Hmm, did I just hit the feature-freeze point with the fixes...
> 
> Now I'm unsure where I should push these (if anywhere), as they already 
> are in drm-misc-next.
> 
> DRM Misc maintainers, can you give me a hint? =)

This is now breaking allmodconfig build of Linus's tree.
Could you please get it fixed ASAP?