x86/mm: remove unused CR3_HW_ASID_BITS

[PATCH] x86/mm: remove unused CR3_HW_ASID_BITS

Posted by Yosry Ahmed 1 year, 9 months ago

Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.

Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
---
 arch/x86/mm/tlb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 44ac64f3a047c..a2ba5bb201705 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -85,9 +85,6 @@
  *
  */
 
-/* There are 12 bits of space for ASIDS in CR3 */
-#define CR3_HW_ASID_BITS		12
-
 /*
  * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
  * user/kernel switches
-- 
2.44.0.769.g3c40516874-goog

Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS

Posted by Kirill A. Shutemov 1 year, 5 months ago

On Thu, Apr 25, 2024 at 09:59:51PM +0000, Yosry Ahmed wrote:
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
> 
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS

Posted by Yosry Ahmed 1 year, 6 months ago

On Thu, Apr 25, 2024 at 2:59 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

I think this may have gotten lost in the noise, friendly ping :)

> ---
>  arch/x86/mm/tlb.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 44ac64f3a047c..a2ba5bb201705 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -85,9 +85,6 @@
>   *
>   */
>
> -/* There are 12 bits of space for ASIDS in CR3 */
> -#define CR3_HW_ASID_BITS               12
> -
>  /*
>   * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
>   * user/kernel switches
> --
> 2.44.0.769.g3c40516874-goog
>

[tip: x86/mm] x86/mm: Remove unused CR3_HW_ASID_BITS

Posted by tip-bot2 for Yosry Ahmed 1 year, 6 months ago

The following commit has been merged into the x86/mm branch of tip:

Commit-ID:     4276a0bb62598966716e1ee1ac4a64d382cc9ef7
Gitweb:        https://git.kernel.org/tip/4276a0bb62598966716e1ee1ac4a64d382cc9ef7
Author:        Yosry Ahmed <yosryahmed@google.com>
AuthorDate:    Thu, 25 Apr 2024 21:59:51 
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 10 Aug 2024 10:47:19 +02:00

x86/mm: Remove unused CR3_HW_ASID_BITS

Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.

Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240425215951.2310105-1-yosryahmed@google.com

---
 arch/x86/mm/tlb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 1fe9ba3..09950fe 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -86,9 +86,6 @@
  *
  */
 
-/* There are 12 bits of space for ASIDS in CR3 */
-#define CR3_HW_ASID_BITS		12
-
 /*
  * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
  * user/kernel switches