[v3] Define i2c_designware in a header file

[PATCH v3 0/5] Define i2c_designware in a header file

Posted by Florian Fainelli 1 week, 4 days ago

This patch series depends upon the following two patches being applied:

https://lore.kernel.org/all/20240422084109.3201-1-duanqiangwen@net-swift.com/
https://lore.kernel.org/all/20240422084109.3201-2-duanqiangwen@net-swift.com/

There is no reason why each driver should have to repeat the
"i2c_designware" string all over the place, because when that happens we
see the reverts like the above being necessary.

Given the dependency on the two other patches above, it would make sense
to route this via the networking tree, or wait until a v6.9-rc
containing the above two changes gets merged into one of the i2c/mfd
trees.

Changes in v3:

- incorporate Andy's change removing the MODULE_ALIAS
- created a separate inclusion group as requested by Andy
- changed the string format in txgbe_phy.c

Changes in v2:

- avoid changing i2c-designware-pcidrv.c more than necessary
- move constant to include/linux/platform_data/i2c-designware.h
- add comments as to how this constant is used and why

Andy Shevchenko (1):
  i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()

Florian Fainelli (4):
  i2c: designware: Create shared header hosting driver name
  mfd: intel-lpss: Utilize i2c-designware.h
  mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h
  net: txgbe: Utilize i2c-designware.h

 MAINTAINERS                                    |  1 +
 drivers/i2c/busses/i2c-designware-pcidrv.c     |  2 --
 drivers/i2c/busses/i2c-designware-platdrv.c    | 12 +++++++++---
 drivers/mfd/intel-lpss.c                       |  3 ++-
 drivers/mfd/intel_quark_i2c_gpio.c             |  6 ++++--
 drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c |  6 ++++--
 include/linux/platform_data/i2c-designware.h   | 12 ++++++++++++
 7 files changed, 32 insertions(+), 10 deletions(-)
 create mode 100644 include/linux/platform_data/i2c-designware.h

-- 
2.34.1

Re: (subset) [PATCH v3 0/5] Define i2c_designware in a header file

Posted by Andi Shyti 4 days, 7 hours ago

Hi

On Thu, 25 Apr 2024 14:44:33 -0700, Florian Fainelli wrote:
> This patch series depends upon the following two patches being applied:
> 
> https://lore.kernel.org/all/20240422084109.3201-1-duanqiangwen@net-swift.com/
> https://lore.kernel.org/all/20240422084109.3201-2-duanqiangwen@net-swift.com/
> 
> There is no reason why each driver should have to repeat the
> "i2c_designware" string all over the place, because when that happens we
> see the reverts like the above being necessary.
> 
> [...]

Applied to i2c/i2c-host on

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Thank you,
Andi

Patches applied
===============
[1/5] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
      commit: 91647e64f0f5677ace84165dc25dc99579147b8f
[2/5] i2c: designware: Create shared header hosting driver name
      commit: 856cd5f13de7cebca44db5ff4bc2ca73490dd8d7

Re: (subset) [PATCH v3 0/5] Define i2c_designware in a header file

Posted by Jarkko Nikula 3 days, 23 hours ago

Hi Andi

On 5/3/24 2:09 AM, Andi Shyti wrote:
> Applied to i2c/i2c-host on
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
> 
> Thank you,
> Andi
> 
> Patches applied
> ===============
> [1/5] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
>        commit: 91647e64f0f5677ace84165dc25dc99579147b8f
> [2/5] i2c: designware: Create shared header hosting driver name
>        commit: 856cd5f13de7cebca44db5ff4bc2ca73490dd8d7
> 
Was the second patch applied accidentally?

Re: (subset) [PATCH v3 0/5] Define i2c_designware in a header file

Posted by Andy Shevchenko 3 days, 14 hours ago

On Fri, May 03, 2024 at 09:30:39AM +0300, Jarkko Nikula wrote:
> On 5/3/24 2:09 AM, Andi Shyti wrote:
> > Applied to i2c/i2c-host on
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
> > 
> > Thank you,
> > Andi
> > 
> > Patches applied
> > ===============
> > [1/5] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
> >        commit: 91647e64f0f5677ace84165dc25dc99579147b8f
> > [2/5] i2c: designware: Create shared header hosting driver name
> >        commit: 856cd5f13de7cebca44db5ff4bc2ca73490dd8d7
> > 
> Was the second patch applied accidentally?

+1 here, asked the same in private communication.

-- 
With Best Regards,
Andy Shevchenko

Re: (subset) [PATCH v3 0/5] Define i2c_designware in a header file

Posted by Andi Shyti 3 days, 11 hours ago

Hi,

On Fri, May 03, 2024 at 06:38:01PM +0300, Andy Shevchenko wrote:
> On Fri, May 03, 2024 at 09:30:39AM +0300, Jarkko Nikula wrote:
> > On 5/3/24 2:09 AM, Andi Shyti wrote:
> > > Applied to i2c/i2c-host on
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
> > > 
> > > Thank you,
> > > Andi
> > > 
> > > Patches applied
> > > ===============
> > > [1/5] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
> > >        commit: 91647e64f0f5677ace84165dc25dc99579147b8f
> > > [2/5] i2c: designware: Create shared header hosting driver name
> > >        commit: 856cd5f13de7cebca44db5ff4bc2ca73490dd8d7
> > > 
> > Was the second patch applied accidentally?
> 
> +1 here, asked the same in private communication.

yes, it is, I had this applied in my branch before reviving the
thread. I then pushed and thanked for everything.

Thanks for your prompt reaction :-)

Andi